Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Update rowcount test #781

Merged
merged 1 commit into from
Sep 19, 2023
Merged

test: Update rowcount test #781

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions duckdb_engine/tests/test_basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,11 +314,10 @@
duckdb.default_connection.execute('comment on sqlite_master is "hello world";')


@mark.xfail(raises=AttributeError)
def test_rowcount() -> None:
import duckdb

duckdb.default_connection.rowcount # type: ignore
assert duckdb.default_connection.rowcount == -1 # type: ignore

Check warning on line 320 in duckdb_engine/tests/test_basic.py

View check run for this annotation

Codecov / codecov/patch

duckdb_engine/tests/test_basic.py#L320 

Added line #L320 was not covered by tests


def test_sessions(session: Session) -> None:
Expand Down