fix: Support fetching multiple databases and schemas and their associated tables #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
Are you able to look at the failing checks? |
guenp
changed the title
…-appear-in-schema-dropdown
|
@Mause, sure thing, I think all checks are passing now. |
Mause
reviewed
Dec 6, 2023
|
Alright, I was able to repro the test failure locally and I think I fixed it now! Just to be 100% sure I ran the CI pipeline here: https://github.com/motherduckdb/duckdb_engine/actions/runs/7118602752. |
|
@Mause This is now ready for review |
|
Thanks! This is now released in 0.9.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picking this up from previous PRs by @Mause and @Alex-Monahan (see #748 and #740)
Due to having multiple databases in DuckDB, the Postgres dialect of get_schema_names has duplicates (Ex: one copy of "main" for every database, including temp and system).
This change adds a method
get_schema_namesthat returns a list of schema names formatted as<db name>.<schema name>and lets you get a schema's associated tables usingget_table_names.