Change to INameable to grab custom name or block name, and highlight fix #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To display custom names instead of default block names, Changed method of returning displayName to iNameable and use getDisplayName over getHoverName.
Fixed block highlighting by utilizing the newer RFToolsBase.highlightBlock method.
DatenThielt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To display custom names instead of default block names, Changed method of returning displayName to lookup iNameable and use getDisplayName over getHoverName.
I have removed what appears to be some method of returning names on Modular storages as it does not work, Also modular storages do not seem to retain their NBT when being placed so naming them in an anvil does not work, unfortunately I have not had a chance to look at why that might be,
Also I have included a fix to update the blockHighlight on double click