Fix merge of boolean experiment variables with string from CLI #1247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes boolean conversion from CLI strings when merging with experiment configuration.
This is the current behavior:
results in
self.save_history_ckpt=True
because the functionmerge()
executes the following code:v = src_type(v)
->self.save_history_ckpt = bool("False")
->self.save_history_ckpt = True
In Python, any non-empty string when cast to bool returns
True
.Naturally, the expected behavior is actually
self.save_history_ckpt = False
.