Skip to content

Commit

Permalink
Fix name of the Slack template input
Browse files Browse the repository at this point in the history
Using a space to separate the two words look like it would work better than a
hyphen ('-') as you can't have a hyphen in an environment variable, which is
necessary for testing this locally.

Spaces are however explicitly changed to underscores in the @actions/core
library so it's clear how that would work, and it's prettier than using an
underscore through out.
  • Loading branch information
Tenzer committed Jan 14, 2022
1 parent 6c644fc commit b05232f
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ Three different output formats are supplied, plain text, Markdown and for Slack.
# - until.short
#
# Default: *Changes from {since.short} to {until.short}*
slacktemplate: ''
slack template: ''
```
Expand Down
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ inputs:
chronological:
description: Output changes in chronological order
default: true
slack-template:
slack template:
description: |
Message template to be used for line above the Slack output.
Expand Down
2 changes: 1 addition & 1 deletion dist/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/index.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ async function run(): Promise<void> {

const since = core.getInput('since') || (await getMostRecentRelease(octokit)) || (await getMostRecentTag(octokit))
let until = core.getInput('until', {required: true})
const slackTemplate = core.getInput('slacktemplate')
const slackTemplate = core.getInput('slack template')

if (!since) {
core.setFailed("`since` was not set and a reasonable default couldn't be established")
Expand Down

0 comments on commit b05232f

Please sign in to comment.