Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name guide argument in hGraph() #25

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Name guide argument in hGraph() #25

merged 1 commit into from
Jan 11, 2024

Conversation

teunbrand
Copy link
Contributor

Hello there,

We have been preparing a new release of ggplot2 and during a reverse dependency check, it became apparent that the prospective ggplot2 3.5.0 would break gMCPLite. The culprit of the breakage is that we have made the name argument of scales the first, see tidyverse/ggplot2#5583.

Because hGraph() passes the legend as an unnamed argument, this gets matched by position to the name argument in the new version of ggplot2. This PR names the guide argument to prevent it being passed to the wrong argument.

To test the code changes with the release candidate, you can install it with the code below:

remotes::install_github("tidyverse/ggplot2", ref = remotes::github_pull("5592"))

The release of ggplot2 3.5.0 is scheduled at the end of January / early Februari. The progress can be tracked in tidyverse/ggplot2#5588.

Copy link
Collaborator

@nanxstats nanxstats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @teunbrand for the patch and detailed explanation. I appreciate the effort. I'm merging this and will send a new release of gMCPLite to CRAN this week.

@nanxstats nanxstats merged commit f87fd75 into Merck:main Jan 11, 2024
7 checks passed
@teunbrand teunbrand deleted the ggplot2_3.5.0 branch January 11, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants