Check factor #152
Merged
Check factor #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangben718
approved these changes
Oct 24, 2023
nanxstats
reviewed
Oct 24, 2023
| # Snapshot testing | ||
| ae_summary <- function(meta, population, observation, parameter) { | ||
| message("run ae_summary") | ||
| return(NULL) |
There was a problem hiding this comment.
Do you mean invisible(NULL)?
nanxstats
reviewed
Oct 24, 2023
| key_obs <- u_plan[i, "observation"] | ||
| level_pop <- levels(meta$data_population[[metalite::collect_adam_mapping(meta, key_pop)$group]]) | ||
| level_obs <- levels(meta$data_observation[[metalite::collect_adam_mapping(meta, key_obs)$group]]) | ||
| if (!all(level_pop == level_obs)) { |
There was a problem hiding this comment.
Is it possible the level values are the same but the orders are different? Meaning a set comparison instead of a exact match comparison. Or are they already sorted?
nanxstats
reviewed
Oct 24, 2023
| @@ -86,5 +88,17 @@ meta_validate <- function(meta) { | |||
| } | |||
| }) | |||
|
|
|||
| # check group factor level are the same | |||
| u_plan <- unique(meta$plan[, c("population", "observation")]) | |||
| for (i in 1:nrow(u_plan)) { | |||
There was a problem hiding this comment.
for (i in seq_len(nrow(u_plan)))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable checking described in #151