296 fix cran pre tests #297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Hi @jdblischak and @nanxstats, it looks like I only changed the DESCRIPTION file but the CMD check on macos is failed. Do you happen to have any thoughts? |
|
We fixed this error in the dev version of {gsDesign2}: #262 (comment) |
jdblischak
requested changes
Nov 5, 2024
There was a problem hiding this comment.
I recommend releasing {gsDesign2} to CRAN (Merck/gsDesign2#480), and then updating the Imports of {simtrial} to require this latest version with >=
|
Thanks for the suggestion! I will prepare the release of gsDesign2 first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix issue #296