Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail in last PR regarding the use of json module #225

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Conversation

ValentinBuira
Copy link
Contributor

There is a typo in my last PR regarding the use of json module

I used json.loads with a s instead of json.load that support de serializing python object and not string

Every use of workspace_service failed in the plugin because of that

@coveralls
Copy link

coveralls commented Dec 6, 2024

Pull Request Test Coverage Report for Build 12768577704

Details

  • 22 of 22 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 79.424%

Totals Coverage Status
Change from base Build 12410385751: 0.05%
Covered Lines: 3254
Relevant Lines: 4097

💛 - Coveralls

Copy link
Contributor

@MarcelGeo MarcelGeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix is ok. We need to update tests to catch these errors for workspace_service method

Copy link
Contributor

@MarcelGeo MarcelGeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I preffer to cancel this PR and do just few things (or rerevert commits)

  • remove just monhtly contributors test manually, do not revert changes (I see there some added print)
  • there was also some minor improvements by me and @VitorVieiraZ
  • add your testing function for workspace

@MarcelGeo MarcelGeo merged commit 0413f86 into master Jan 16, 2025
6 of 8 checks passed
@MarcelGeo MarcelGeo deleted the fix-typo-parsing branch January 16, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants