-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker fix #18
docker fix #18
Conversation
https://github.com/MetaCubeX/subconverter/actions/runs/11451948896/workflow Actually, the previous action for docker build works, and I've reset the commit to it currently. |
@Larvan2 No. The build works but the manifest merge doesn't. It doesn't report an error for it. You can check the step here.
The previous manifest merge is not working for multi-arch anymore. You can check the commit in upstream probject here. You can use the command to inspect the docker build. Only ARM is available.
You will see that only arm64 is available in the manifest. It means that the manifest merge failed.
|
That was my mistake. However, I believe the ARM build is worth keeping. Is it possible to retain the ARM build of Docker? |
@Larvan2 Can you please have a try on this? I have an update on it. It may help. https://github.com/SetoKaiba/subconverter/actions/runs/11459535371
|
@Larvan2 It's finally fixed for docker. I check the manifest and the image. Both are correct. Thank you for the merging. |
Thanks for your great jobs 🎉. |
https://github.com/MetaCubeX/subconverter/actions/runs/11365668185
@Larvan2 I found that the problem is caused by the lack of ARM/ARM64 environment.
So I remove the build of the ARM/ARM64 builidng.
It should fix the docker build now.
And here's the github action running without ARM/ARM64 in my repo.
And it successfully finished with merge job finished.
https://github.com/SetoKaiba/subconverter/actions/runs/11396629393