Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker fix #18

Merged
merged 1 commit into from
Oct 23, 2024
Merged

docker fix #18

merged 1 commit into from
Oct 23, 2024

Conversation

SetoKaiba
Copy link

https://github.com/MetaCubeX/subconverter/actions/runs/11365668185
@Larvan2 I found that the problem is caused by the lack of ARM/ARM64 environment.
So I remove the build of the ARM/ARM64 builidng.
It should fix the docker build now.

And here's the github action running without ARM/ARM64 in my repo.
And it successfully finished with merge job finished.
https://github.com/SetoKaiba/subconverter/actions/runs/11396629393

{
   "schemaVersion": 2,
   "mediaType": "application/vnd.oci.image.index.v1+json",
   "manifests": [
      {
         "mediaType": "application/vnd.oci.image.manifest.v1+json",
         "size": 860,
         "digest": "sha256:dead3d2d1bcdecb3bf44fa31c7b55185f7d39ee7e5e1e8586c23bfa835298f58",
         "platform": {
            "architecture": "amd64",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.oci.image.manifest.v1+json",
         "size": 567,
         "digest": "sha256:eb68d1bd3f82e4103e89ccd4d18af5bd54908ed6cdfe33cd7b9635be7fac6037",
         "platform": {
            "architecture": "unknown",
            "os": "unknown"
         }
      },
      {
         "mediaType": "application/vnd.oci.image.manifest.v1+json",
         "size": 860,
         "digest": "sha256:8281e310d0294c0508fe7e12e91130d835964e4002e17a113f9d0399ca4572ee",
         "platform": {
            "architecture": "386",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.oci.image.manifest.v1+json",
         "size": 567,
         "digest": "sha256:fa8440010183ea73f3fdfe357feec88aba47a841d560af785e6e2407dbcd1c99",
         "platform": {
            "architecture": "unknown",
            "os": "unknown"
         }
      }
   ]
}

@Larvan2
Copy link

Larvan2 commented Oct 22, 2024

https://github.com/MetaCubeX/subconverter/actions/runs/11451948896/workflow

Actually, the previous action for docker build works, and I've reset the commit to it currently.

@SetoKaiba
Copy link
Author

SetoKaiba commented Oct 22, 2024

@Larvan2 No. The build works but the manifest merge doesn't. It doesn't report an error for it. You can check the step here.
https://github.com/MetaCubeX/subconverter/actions/runs/11451948896/job/31862479373
Please check the Merge and push manifest on master branch step.

Run python scripts/merge_manifest.py
ghcr.io/metacubex/subconverter@sha256:16a117c7f62ca0e8897c016d5e[4](https://github.com/MetaCubeX/subconverter/actions/runs/11451948896/job/31862479373#step:7:5)21a9a662c4f74af470f56ac2b6211577fd536 is a manifest list
No such manifest: ghcr.io/metacubex/subconverter:latest

The previous manifest merge is not working for multi-arch anymore.

You can check the commit in upstream probject here.
tindy2013@fb2aca3

You can use the command to inspect the docker build. Only ARM is available.

docker manifest inspect ghcr.io/metacubex/subconverter

You will see that only arm64 is available in the manifest. It means that the manifest merge failed.
Please have a check. Thank you.

{
   "schemaVersion": 2,
   "mediaType": "application/vnd.oci.image.index.v1+json",
   "manifests": [
      {
         "mediaType": "application/vnd.oci.image.manifest.v1+json",
         "size": 860,
         "digest": "sha256:055f9c5fe69afce221a263f48144bda5f79c16c223811e2cba73a17edbed00e7",
         "platform": {
            "architecture": "arm64",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.oci.image.manifest.v1+json",
         "size": 566,
         "digest": "sha256:a0ab8fb83737ac43a15086afc790c39e88b3c0868c185680195273c073cc2289",
         "platform": {
            "architecture": "unknown",
            "os": "unknown"
         }
      }
   ]
}

@Larvan2
Copy link

Larvan2 commented Oct 22, 2024

That was my mistake.

However, I believe the ARM build is worth keeping. Is it possible to retain the ARM build of Docker?

@SetoKaiba
Copy link
Author

SetoKaiba commented Oct 22, 2024

That was my mistake.

However, I believe the ARM build is worth keeping. Is it possible to retain the ARM build of Docker?

@Larvan2 Can you please have a try on this? I have an update on it. It may help.

https://github.com/SetoKaiba/subconverter/actions/runs/11459535371
I confirmed that the arm builds finished successfully. And the manifest is merged.

{
   "schemaVersion": 2,
   "mediaType": "application/vnd.oci.image.index.v1+json",
   "manifests": [
      {
         "mediaType": "application/vnd.oci.image.manifest.v1+json",
         "size": 860,
         "digest": "sha256:c96cf7c8290dcad126311ec2c667a88c3060a1f20bc44c1ff74ee23128384bd7",
         "platform": {
            "architecture": "amd64",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.oci.image.manifest.v1+json",
         "size": 567,
         "digest": "sha256:0d76ed20cb8fcf8ad312c38b08b2e765c860c42fb6a3d467e5ba35b0a6d0659c",
         "platform": {
            "architecture": "unknown",
            "os": "unknown"
         }
      },
      {
         "mediaType": "application/vnd.oci.image.manifest.v1+json",
         "size": 860,
         "digest": "sha256:3346a612bae856452ae3d24fed6884f46392e236513abc8ac542e29cb6506a63",
         "platform": {
            "architecture": "arm64",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.oci.image.manifest.v1+json",
         "size": 567,
         "digest": "sha256:43344a22c4f7dee2bb60d6d218fea0c61c3efd2969c16938733c48084c790795",
         "platform": {
            "architecture": "unknown",
            "os": "unknown"
         }
      },
      {
         "mediaType": "application/vnd.oci.image.manifest.v1+json",
         "size": 860,
         "digest": "sha256:f0a689a6a9629fa94749e08dfd65d417fdee7f73543442588b498b28034b954f",
         "platform": {
            "architecture": "arm",
            "os": "linux",
            "variant": "v7"
         }
      },
      {
         "mediaType": "application/vnd.oci.image.manifest.v1+json",
         "size": 567,
         "digest": "sha256:6e348fd84486d9966ce6629969e9d24d1b40ca20e447a722e84b9c39a2176436",
         "platform": {
            "architecture": "unknown",
            "os": "unknown"
         }
      },
      {
         "mediaType": "application/vnd.oci.image.manifest.v1+json",
         "size": 860,
         "digest": "sha256:0f450df184d3a7b4b10c51f75973f44af626d304f08c96dcf24309311b4be986",
         "platform": {
            "architecture": "386",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.oci.image.manifest.v1+json",
         "size": 567,
         "digest": "sha256:6caceac5d18806f0fb846be9f17254d343bae6c2c02cb8aa9415667f6647cd4a",
         "platform": {
            "architecture": "unknown",
            "os": "unknown"
         }
      }
   ]
}

@Larvan2 Larvan2 merged commit 1c46bc9 into MetaCubeX:master Oct 23, 2024
6 of 9 checks passed
@SetoKaiba
Copy link
Author

@Larvan2 It's finally fixed for docker. I check the manifest and the image. Both are correct. Thank you for the merging.

@Larvan2
Copy link

Larvan2 commented Oct 23, 2024

@Larvan2 It's finally fixed for docker. I check the manifest and the image. Both are correct. Thank you for the merging.

Thanks for your great jobs 🎉.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants