New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve and update Keyring docs #1034

Merged

alexandratran merged 11 commits into main from 1030-keyring

Dec 12, 2023

Contributor

alexandratran commented Dec 2, 2023 •

edited

Loading

Update the Keyring API content for clarity and integrate updates from latest releases. Additional edits to related content.
Fixes #1030

Previews:

About the Keyring API: https://docs.metamask.io/1030-keyring/snaps/concepts/keyring-api/
How to create an account management Snap: https://docs.metamask.io/1030-keyring/snaps/how-to/use-keyring-api/create-account-snap/
Account management Snap security guidelines: https://docs.metamask.io/1030-keyring/snaps/how-to/use-keyring-api/security/
Create an account management companion dapp: https://docs.metamask.io/1030-keyring/snaps/how-to/use-keyring-api/create-companion-dapp/

alexandratran added 2 commits

December 2, 2023 00:10


          Improve and update Keyring docs

eaa0fce


          edits

cd3e076

github-actions bot commented Dec 3, 2023

Preview published: 1030-keyring

alexandratran added 2 commits

December 2, 2023 17:05


          doc signing methods


          edits

ef7139f

github-actions bot commented Dec 4, 2023

Preview published: 1030-keyring

alexandratran marked this pull request as ready for review

December 4, 2023 20:14

alexandratran requested review from a team as code owners

December 4, 2023 20:14

alexandratran requested a review from a team

December 4, 2023 20:14

AlexJupiter added team-accounts and removed team-accounts labels


          keyring snap -> account management snap

020a9c0

github-actions bot commented Dec 5, 2023

Preview published: 1030-keyring

Montoya approved these changes

View reviewed changes

Collaborator

Montoya left a comment

LGTM

alexandratran requested a review from danroc

December 6, 2023 07:29

danroc reviewed

View reviewed changes

snaps/concepts/keyring-api.md Outdated Show resolved Hide resolved

danroc reviewed

View reviewed changes

snaps/concepts/keyring-api.md Outdated Show resolved Hide resolved

danroc reviewed

View reviewed changes

snaps/how-to/use-keyring-api/dapp.md Outdated Show resolved Hide resolved

alexandratran added 2 commits

December 8, 2023 10:44


          Merge branch 'main' into 1030-keyring

83630e9


          eth_signTransaction

6602e4c

github-actions bot commented Dec 8, 2023

Preview published: 1030-keyring

danroc approved these changes

View reviewed changes

alexandratran added 2 commits

December 11, 2023 19:06


          restructure + dapp -> companion dapp

fe2f402


          fix redirect

2935fab

github-actions bot commented Dec 12, 2023

Preview published: 1030-keyring

mjsmike62 reviewed

View reviewed changes

snaps/how-to/use-keyring-api/create-account-snap.md Show resolved Hide resolved

mjsmike62 reviewed

View reviewed changes

snaps/how-to/use-keyring-api/create-account-snap.md Show resolved Hide resolved

mjsmike62 reviewed

View reviewed changes

snaps/how-to/use-keyring-api/create-account-snap.md Outdated Show resolved Hide resolved

mjsmike62 reviewed

View reviewed changes

snaps/how-to/use-keyring-api/create-account-snap.md Outdated Show resolved Hide resolved

mjsmike62 reviewed

View reviewed changes

snaps/how-to/use-keyring-api/create-account-snap.md Show resolved Hide resolved

mjsmike62 reviewed

View reviewed changes

snaps/how-to/use-keyring-api/create-account-snap.md Show resolved Hide resolved

mjsmike62 reviewed

View reviewed changes

snaps/how-to/use-keyring-api/create-account-snap.md Outdated Show resolved Hide resolved

mjsmike62 reviewed

View reviewed changes

snaps/how-to/use-keyring-api/create-account-snap.md Outdated Show resolved Hide resolved

mjsmike62 reviewed

View reviewed changes

snaps/how-to/use-keyring-api/create-account-snap.md Outdated Show resolved Hide resolved

mjsmike62 reviewed

View reviewed changes

snaps/how-to/use-keyring-api/create-account-snap.md Outdated Show resolved Hide resolved

mjsmike62 reviewed

View reviewed changes

snaps/how-to/use-keyring-api/security.md Show resolved Hide resolved

mjsmike62 reviewed

View reviewed changes

snaps/reference/rpc-api.md Show resolved Hide resolved

mjsmike62 approved these changes

View reviewed changes

Contributor

mjsmike62 left a comment

I have a few suggested edits.

alexandratran added 2 commits

December 12, 2023 11:58


          Merge branch 'main' into 1030-keyring

b95568d


          address reviewer feedback

85c8c8a

github-actions bot commented Dec 12, 2023

Preview published: 1030-keyring

alexandratran merged commit 2f5e7f6 into main

6 checks passed

alexandratran deleted the 1030-keyring branch

December 12, 2023 20:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet