Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snaps: Update snap_notify to include expanded view #1774

Merged
merged 10 commits into from
Dec 16, 2024
Merged

Conversation

Montoya
Copy link
Collaborator

@Montoya Montoya commented Dec 12, 2024

Description

Update snap_notify method to include expanded view parameters and multiple examples.

Update Snap feature page for notifications to include expanded view.

Update Custom UI to include notification expanded view to the list of areas that can use JSX.

Issue(s) fixed

Fixes #1544

Preview

Checklist

Complete this checklist before merging your PR:

  • If this PR contains a major change to the documentation content, I have added an entry to the top of the "What's new?" page.
  • The proposed changes have been reviewed and approved by a member of the documentation team.

@Montoya Montoya requested review from a team as code owners December 12, 2024 22:32
Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metamask-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 2:59am

Copy link
Contributor

@bgravenorst bgravenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback.

Also, I assume this does not return a result? But would it make sense to have the "Returns" heading and mention that it doesn't return anything.

snaps/reference/snaps-api.md Outdated Show resolved Hide resolved
snaps/reference/snaps-api.md Outdated Show resolved Hide resolved
snaps/reference/snaps-api.md Outdated Show resolved Hide resolved
snaps/reference/snaps-api.md Outdated Show resolved Hide resolved
Co-authored-by: Byron Gravenorst <50852695+bgravenorst@users.noreply.github.com>
@Montoya Montoya marked this pull request as ready for review December 13, 2024 17:46
@Montoya
Copy link
Collaborator Author

Montoya commented Dec 13, 2024

Also, I assume this does not return a result? But would it make sense to have the "Returns" heading and mention that it doesn't return anything.

We don't do that for other methods that do not return a result, so it's consistent for now.

hmalik88
hmalik88 previously approved these changes Dec 13, 2024
hmalik88
hmalik88 previously approved these changes Dec 13, 2024
bgravenorst
bgravenorst previously approved these changes Dec 15, 2024
Copy link
Contributor

@bgravenorst bgravenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

snaps/features/notifications.md Outdated Show resolved Hide resolved
@bgravenorst bgravenorst dismissed stale reviews from hmalik88 and themself via a21a79c December 15, 2024 21:16
@Montoya Montoya merged commit 1e2f55d into main Dec 16, 2024
20 checks passed
@Montoya Montoya deleted the update-snap_notify branch December 16, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snaps: Update snap_notify documentation with expanded view feature
3 participants