-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snaps: Update snap_notify to include expanded view #1774
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some feedback.
Also, I assume this does not return a result? But would it make sense to have the "Returns" heading and mention that it doesn't return anything.
Co-authored-by: Byron Gravenorst <50852695+bgravenorst@users.noreply.github.com>
We don't do that for other methods that do not return a result, so it's consistent for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
Description
Update
snap_notify
method to include expanded view parameters and multiple examples.Update Snap feature page for notifications to include expanded view.
Update Custom UI to include notification expanded view to the list of areas that can use JSX.
Issue(s) fixed
Fixes #1544
Preview
Checklist
Complete this checklist before merging your PR: