fix: confirmation when transaction (STX) is pending cross-network #25629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #25629 +/- ##
========================================
Coverage 69.67% 69.68%
========================================
Files 1366 1366
Lines 48231 48237 +6
Branches 13304 13306 +2
========================================
+ Hits 33604 33610 +6
Misses 14627 14627 ☔ View full report in Codecov by Sentry. |
Builds ready [784cd3d]
Page Load Metrics (166 ± 166 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [9672ed5]
Page Load Metrics (285 ± 266 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
User cannot send another transaction while having STX in 123.mov |
|
Should all types of txs be disabled if user has Confusing UX when tx are of
approval.movThe error in the console when the STX gets confirmed: 
|
7 tasks
pedronfigueiredo
previously approved these changes
Jul 3, 2024
matthewwalsh0
previously approved these changes
Jul 3, 2024
| }, | ||
| (transactions) => transactions, | ||
| ); | ||
|
|
||
| export const getCurrentNetworkTransactions = createDeepEqualSelector( |
There was a problem hiding this comment.
Should we change this to use getTransactions as a dependency to avoid the duplicated sorting?
There was a problem hiding this comment.
I tried that yesterday but some of the unit tests started to fail. After your comment, I tried again, found the issue in the unit tests, and pushed this change to use getTransactions.
vinistevam
dismissed stale reviews from matthewwalsh0 and pedronfigueiredo
via
c3aac51
|
Builds ready [fe62ee6]
Page Load Metrics (406 ± 326 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
pedronfigueiredo
approved these changes
Jul 4, 2024
matthewwalsh0
approved these changes
Jul 4, 2024
metamaskbot
added
the
release-12.2.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix the issue when a user has a Smart transaction in a pending state and initiates a new transaction through a dApp on a different network, the dApp transaction is generated with an empty nonce.
The issue happens due to a limitation on nonce management in the Transaction Controller. The nonce locks for the first transaction (STX) and only allows the user to submit another transaction once the first one is confirmed. This is the current behaviour for STX with transactions in the same network. This update extends the validation across different networks.
Related issues
Fixes: #25579
Manual testing steps
Screenshots/Recordings
Screencast.from.02-07-2024.14.05.18.webm
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist