Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace Typography with Text component in metametrics.js #25630

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Jul 2, 2024

Description

Migrated the Typography component to the Text component in the metametrics.js file. This change is part of the ongoing effort to update the codebase to use the new Text component for better consistency and maintainability.

Devin Run Link: https://staging.itsdev.in/devin/ab3388199a904772b66d750b70b340af

Open in GitHub Codespaces

Related issues

Partially Fixes: #17670

Manual testing steps

  1. Go to the latest build of storybook in this PR
  2. Verify that the OnboardingMetametrics component renders correctly
  3. Ensure that the text styles and alignments are consistent with the design specifications

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Jul 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarcloud bot commented Jul 2, 2024

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.60%. Comparing base (548b54a) to head (8ea961a).
Report is 73 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25630   +/-   ##
========================================
  Coverage    69.60%   69.60%           
========================================
  Files         1364     1364           
  Lines        48173    48173           
  Branches     13291    13291           
========================================
  Hits         33527    33527           
  Misses       14646    14646           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [8ea961a]
Page Load Metrics (68 ± 14 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint592811004522
domContentLoaded98028178
load39182682914
domInteractive98028178
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -192 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Jul 15, 2024
@georgewrmarshall georgewrmarshall requested a review from a team July 15, 2024 17:39
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

  • Checked OnboardingMetametrics storybook ✅

@georgewrmarshall georgewrmarshall marked this pull request as ready for review July 23, 2024 23:52
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner July 23, 2024 23:52
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Refactored metametrics.js to replace the Typography component with the Text component for improved consistency and maintainability.

  • Updated /ui/pages/onboarding-flow/metametrics/metametrics.js to replace all instances of Typography with Text.
  • Adjusted import statements to include Text from ../../../components/component-library.
  • Ensured correct usage of Text component props for alignment, font weight, and text variants.
  • Verified no visual regressions through before and after screenshots.
  • Thorough testing recommended to confirm no functionality or appearance changes.

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link
Contributor

@garrettbear garrettbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice

@garrettbear garrettbear merged commit d4c2256 into develop Jul 24, 2024
75 checks passed
@garrettbear garrettbear deleted the devin/typography-UgYY branch July 24, 2024 00:57
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2024
@metamaskbot metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Jul 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated Typography with Text component
3 participants