Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace Typography with Text component in restore-vault.js #25636

Merged
merged 4 commits into from
Jul 30, 2024

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Jul 2, 2024

Description

This pull request includes the migration of the Typography component to the Text component in the restore-vault.js file within the MetaMask extension repository. The changes involve replacing all instances of the Typography component with the equivalent Text component and ensuring that the component APIs are properly migrated. The motivation for this change is to align with the updated design system and improve the consistency of the codebase.

Devin Run Link: https://preview.devin.ai/devin/aeebb66ed7a14386ae48164acd4b2e72

Open in GitHub Codespaces

Related issues

Partially Fixes: #17670

Manual testing steps

  1. Go to the latest build of storybook in this PR
  2. Verify that the "RestoreVaultPage" renders correctly with the Text component
  3. Ensure that the text content and styling are consistent with the design specifications

Screenshots/Recordings

Before

Before

After

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

This Devin run was requested by Devin.

Copy link
Contributor

github-actions bot commented Jul 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Jul 15, 2024
@georgewrmarshall georgewrmarshall requested a review from a team July 15, 2024 17:39
@georgewrmarshall georgewrmarshall added team-ai AI team (for the Devin AI bot) and removed external-contributor labels Jul 25, 2024
Copy link

sonarcloud bot commented Jul 26, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [7414ac6]
Page Load Metrics (263 ± 285 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint664771218440
domContentLoaded985362010
load402471263593285
domInteractive985362010
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -2 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.93%. Comparing base (182f609) to head (7414ac6).
Report is 15 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25636   +/-   ##
========================================
  Coverage    69.93%   69.93%           
========================================
  Files         1409     1409           
  Lines        49786    49786           
  Branches     13769    13769           
========================================
  Hits         34817    34817           
  Misses       14969    14969           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • checked storybook ✅

@georgewrmarshall georgewrmarshall marked this pull request as ready for review July 30, 2024 00:22
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner July 30, 2024 00:22
@garrettbear garrettbear merged commit a1ccf1f into develop Jul 30, 2024
76 checks passed
@garrettbear garrettbear deleted the devin/typography-7fL branch July 30, 2024 16:39
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2024
@metamaskbot metamaskbot added the release-12.4.0 Issue or pull request that will be included in release 12.4.0 label Jul 30, 2024
@gauthierpetetin gauthierpetetin added release-12.3.0 Issue or pull request that will be included in release 12.3.0 and removed release-12.4.0 Issue or pull request that will be included in release 12.4.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-ai AI team (for the Devin AI bot) team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated Typography with Text component
4 participants