Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace deprecated mixins with Text component in slippage-buttons #25638

Merged
merged 9 commits into from
Aug 12, 2024

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Jul 2, 2024

Description

This pull request replaces deprecated mixins @include H1 - @include H9 in SCSS with the Text component in the "MetaMask/metamask-extension" repository. The changes are made in the ui/pages/swaps/slippage-buttons/index.scss and slippage-buttons.js files.

  1. What is the reason for the change?

    • The deprecated mixins @include H1 - @include H9 need to be replaced with the Text component to ensure consistency and maintainability in the codebase.
  2. What is the improvement/solution?

    • The deprecated mixins are replaced with the Text component, and the corresponding CSS properties are mapped to the Text component props.

Devin Run Link : https://preview.devin.ai/devin/78aa98c3ee2b43c685a605db902abe1a

Requested by: Devin

Open in GitHub Codespaces

Related issues

Partially Fixes: #20496

Manual testing steps

  1. Go to the latest build of storybook in this PR
  2. Verify that the SlippageButtons component renders correctly with the updated Text components.
  3. Ensure that the styles and functionality of the component remain consistent with the previous implementation.

Screenshots/Recordings

Before

Before Changes

After

After Changes

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability.
  • I’ve included tests if applicable.
  • I’ve documented my code using JSDoc format if applicable.
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Jul 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.96%. Comparing base (7a1191b) to head (f1ceba5).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25638   +/-   ##
========================================
  Coverage    69.96%   69.96%           
========================================
  Files         1411     1411           
  Lines        49946    49946           
  Branches     13805    13805           
========================================
  Hits         34942    34942           
  Misses       15004    15004           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [7ed0f75]
Page Load Metrics (160 ± 187 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint75131105178
domContentLoaded104723115
load461852160388187
domInteractive104723115
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 546 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Jul 15, 2024
@georgewrmarshall georgewrmarshall requested a review from a team July 15, 2024 17:39
@georgewrmarshall georgewrmarshall added team-ai AI team (for the Devin AI bot) and removed external-contributor labels Jul 25, 2024
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions

ui/pages/swaps/slippage-buttons/slippage-buttons.js Outdated Show resolved Hide resolved
ui/pages/swaps/slippage-buttons/slippage-buttons.js Outdated Show resolved Hide resolved
ui/pages/swaps/slippage-buttons/slippage-buttons.js Outdated Show resolved Hide resolved
ui/pages/swaps/slippage-buttons/slippage-buttons.js Outdated Show resolved Hide resolved
ui/pages/swaps/slippage-buttons/slippage-buttons.js Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Jul 30, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [f1ceba5]
Page Load Metrics (758 ± 407 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint804041539143
domContentLoaded106624157
load492157758848407
domInteractive106624157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 422 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • checked storybook PR build against develop storybook ✅

@georgewrmarshall georgewrmarshall marked this pull request as ready for review July 30, 2024 19:53
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner July 30, 2024 19:53
Copy link
Contributor

@garrettbear garrettbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georgewrmarshall georgewrmarshall merged commit 13fec63 into develop Aug 12, 2024
75 checks passed
@georgewrmarshall georgewrmarshall deleted the devin/mixin-7xP branch August 12, 2024 15:45
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2024
@metamaskbot metamaskbot added the release-12.4.0 Issue or pull request that will be included in release 12.4.0 label Aug 12, 2024
@gauthierpetetin gauthierpetetin added release-12.3.0 Issue or pull request that will be included in release 12.3.0 and removed release-12.4.0 Issue or pull request that will be included in release 12.4.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-ai AI team (for the Devin AI bot) team-design-system All issues relating to design system in Extension
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Replace deprecated mixins @include H1 - @include H9 in SCSS with Text component
5 participants