-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace deprecated mixins with Text component in slippage-buttons #25638
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25638 +/- ##
========================================
Coverage 69.96% 69.96%
========================================
Files 1411 1411
Lines 49946 49946
Branches 13805 13805
========================================
Hits 34942 34942
Misses 15004 15004 ☔ View full report in Codecov by Sentry. |
Builds ready [7ed0f75]
Page Load Metrics (160 ± 187 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some suggestions
Co-authored-by: Garrett Bear <garrett.whisten@consensys.net>
Quality Gate passedIssues Measures |
Builds ready [f1ceba5]
Page Load Metrics (758 ± 407 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- checked storybook PR build against
develop
storybook ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This pull request replaces deprecated mixins @include H1 - @include H9 in SCSS with the Text component in the "MetaMask/metamask-extension" repository. The changes are made in the
ui/pages/swaps/slippage-buttons/index.scss
andslippage-buttons.js
files.What is the reason for the change?
What is the improvement/solution?
Devin Run Link : https://preview.devin.ai/devin/78aa98c3ee2b43c685a605db902abe1a
Requested by: Devin
Related issues
Partially Fixes: #20496
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist