Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix page width for fullscreen mode send page #25639

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

hmalik88
Copy link
Contributor

@hmalik88 hmalik88 commented Jul 2, 2024

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions:

  1. What is the reason for the change? The send page was too wide in full screen mode
  2. What is the improvement/solution? Added a media query to handle page width in fulls screen mode.

Manual testing steps

  1. Build the extension
  2. Open the send screen in full page view

Screenshots/Recordings

Before

MetaMask.-.Brave.2024-06-13.15-56-48.mp4

After

Screenshot 2024-07-02 at 12 48 32 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Jul 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jul 2, 2024
Copy link

sonarcloud bot commented Jul 2, 2024

@metamaskbot metamaskbot added the team-snaps-platform Snaps Platform team label Jul 2, 2024
@hmalik88 hmalik88 added team-extension-platform and removed INVALID-PR-TEMPLATE PR's body doesn't match template team-snaps-platform Snaps Platform team labels Jul 2, 2024
@hmalik88 hmalik88 marked this pull request as ready for review July 2, 2024 16:57
@hmalik88 hmalik88 requested a review from a team as a code owner July 2, 2024 16:57
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.66%. Comparing base (7b69e3c) to head (089c41c).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25639   +/-   ##
========================================
  Coverage    69.66%   69.66%           
========================================
  Files         1366     1366           
  Lines        48215    48215           
  Branches     13301    13301           
========================================
  Hits         33588    33588           
  Misses       14627    14627           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [089c41c]
Page Load Metrics (236 ± 234 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint76143103168
domContentLoaded116931147
load441764236487234
domInteractive116931147
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@darkwing darkwing added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Jul 2, 2024
@darkwing darkwing merged commit 2726c5d into develop Jul 11, 2024
89 of 90 checks passed
@darkwing darkwing deleted the hm/fix-fullscreen-send-page branch July 11, 2024 14:27
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2024
@metamaskbot metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Jul 11, 2024
@metamaskbot metamaskbot added release-12.2.0 Issue or pull request that will be included in release 12.2.0 and removed release-12.3.0 Issue or pull request that will be included in release 12.3.0 labels Aug 19, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-12.2.0 on PR. Adding release label release-12.2.0 on PR and removing other release labels(release-12.3.0), as PR was added to branch 12.2.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.2.0 Issue or pull request that will be included in release 12.2.0 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants