Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [Snaps E2E] remove unnecessary steps from snaps UI Images test #25640

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

bowensanders
Copy link
Contributor

@bowensanders bowensanders commented Jul 2, 2024

Description

This is one of a number of tests that have identified as flaky. In this case the test can fail, but it fails after successfully completing. In this test i've removed two unnecessary steps at the end of the test and fixed a typo.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. CI passing shows the test works

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bowensanders bowensanders added area-snaps e2e-test End to end test for the MetaMask extension flaky tests team-snaps-platform Snaps Platform team labels Jul 2, 2024
@bowensanders bowensanders self-assigned this Jul 2, 2024
Copy link
Contributor

github-actions bot commented Jul 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarcloud bot commented Jul 25, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [4cedb20]
Page Load Metrics (218 ± 210 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint702781064421
domContentLoaded1092332110
load421580218438210
domInteractive1092332110
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@bowensanders bowensanders marked this pull request as ready for review July 26, 2024 22:18
@bowensanders bowensanders requested a review from a team as a code owner July 26, 2024 22:18
@bowensanders bowensanders merged commit aa21fa4 into develop Jul 29, 2024
75 of 76 checks passed
@bowensanders bowensanders deleted the bowen/imgsdeflake branch July 29, 2024 18:51
@github-actions github-actions bot locked and limited conversation to collaborators Jul 29, 2024
@metamaskbot metamaskbot added the release-12.4.0 Issue or pull request that will be included in release 12.4.0 label Jul 29, 2024
@gauthierpetetin gauthierpetetin added release-12.3.0 Issue or pull request that will be included in release 12.3.0 and removed release-12.4.0 Issue or pull request that will be included in release 12.4.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-snaps e2e-test End to end test for the MetaMask extension flaky tests release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants