Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set network client id for domain #25646

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Jul 2, 2024

Description

The goal of this PR is to fix the network switch on dapp context

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to metamask test dapp
  2. Choose any testnet ( sepolia for example )
  3. Connect to dapp
  4. close the extension than open it
  5. network should stay on sepolia

Screenshots/Recordings

Before

Screen.Recording.2024-07-02.at.15.15.49.mov

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@salimtb salimtb requested a review from a team as a code owner July 2, 2024 22:32
Copy link
Contributor

github-actions bot commented Jul 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb added team-assets needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Jul 2, 2024
@salimtb salimtb changed the title Salim/fix set network client id for domain fix: set network client id for domain Jul 2, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [0e4330d]
Page Load Metrics (174 ± 179 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint813611235928
domContentLoaded126728157
load561787174373179
domInteractive116728157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 48 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 65.51724% with 10 lines in your changes missing coverage. Please review.

Project coverage is 69.68%. Comparing base (ce3c57c) to head (43c3428).
Report is 4 commits behind head on develop.

Files Patch % Lines
.../multichain/network-list-menu/network-list-menu.js 65.52% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #25646      +/-   ##
===========================================
+ Coverage    69.67%   69.68%   +0.01%     
===========================================
  Files         1366     1366              
  Lines        48226    48219       -7     
  Branches     13303    13296       -7     
===========================================
- Hits         33599    33598       -1     
+ Misses       14627    14621       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@salimtb salimtb force-pushed the salim/fix-set-network-clientId-for-domain branch from e0b9be1 to 43c3428 Compare July 3, 2024 09:07
Copy link

sonarcloud bot commented Jul 3, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [43c3428]
Page Load Metrics (59 ± 6 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6911090136
domContentLoaded95127126
load388359136
domInteractive95127126
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -336 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@salimtb salimtb merged commit a1285f1 into develop Jul 4, 2024
73 checks passed
@salimtb salimtb deleted the salim/fix-set-network-clientId-for-domain branch July 4, 2024 07:58
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2024
@metamaskbot metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.2.0 Issue or pull request that will be included in release 12.2.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants