Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tests): add btc e2e tests #25663

Merged
merged 92 commits into from
Jul 16, 2024
Merged

feat(tests): add btc e2e tests #25663

merged 92 commits into from
Jul 16, 2024

Conversation

montelaidev
Copy link
Contributor

@montelaidev montelaidev commented Jul 3, 2024

Description

This PR adds e2e tests for the preinstalled BTC account in flask.

Related issues

Depends on #25672

Fixes https://github.com/MetaMask/accounts-planning/issues/479

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Jul 3, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@montelaidev montelaidev marked this pull request as ready for review July 11, 2024 05:42
@montelaidev montelaidev requested review from a team as code owners July 11, 2024 05:42
test/e2e/accounts/common.ts Outdated Show resolved Hide resolved
test/e2e/helpers.js Outdated Show resolved Hide resolved
@metamaskbot
Copy link
Collaborator

Builds ready [5902636]
Page Load Metrics (143 ± 158 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint701561002010
domContentLoaded96622147
load421573143329158
domInteractive96622147
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [89a85b6]
Page Load Metrics (72 ± 10 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint70140101209
domContentLoaded96630168
load40114722110
domInteractive96630168
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

test/e2e/flask/btc/create-btc-account.spec.ts Outdated Show resolved Hide resolved
test/e2e/flask/btc/btc-experimental-settings.spec.ts Outdated Show resolved Hide resolved
test/e2e/flask/btc/btc-experimental-settings.spec.ts Outdated Show resolved Hide resolved
test/e2e/flask/btc/create-btc-account.spec.ts Show resolved Hide resolved
test/e2e/flask/btc/create-btc-account.spec.ts Outdated Show resolved Hide resolved
test/e2e/flask/btc/create-btc-account.spec.ts Outdated Show resolved Hide resolved
test/e2e/flask/btc/create-btc-account.spec.ts Outdated Show resolved Hide resolved
test/e2e/flask/btc/create-btc-account.spec.ts Outdated Show resolved Hide resolved
test/e2e/flask/btc/create-btc-account.spec.ts Outdated Show resolved Hide resolved
montelaidev and others added 4 commits July 12, 2024 20:53
Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
@metamaskbot
Copy link
Collaborator

Builds ready [eb37113]
Page Load Metrics (215 ± 213 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint59145972110
domContentLoaded96527147
load471594215445213
domInteractive96527147
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

test/e2e/flask/btc/btc-account-overview.spec.ts Outdated Show resolved Hide resolved
test/e2e/flask/btc/btc-account-overview.spec.ts Outdated Show resolved Hide resolved
test/e2e/flask/btc/btc-account-overview.spec.ts Outdated Show resolved Hide resolved
test/e2e/accounts/common.ts Outdated Show resolved Hide resolved
montelaidev and others added 3 commits July 15, 2024 21:33
Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
Copy link

sonarcloud bot commented Jul 15, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [4a97a6f]
Page Load Metrics (76 ± 10 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint67129103178
domContentLoaded107035178
load51113762010
domInteractive107035178
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@pedronfigueiredo pedronfigueiredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

privacy-snapshot.json LGTM

@montelaidev montelaidev merged commit 8a30946 into develop Jul 16, 2024
79 checks passed
@montelaidev montelaidev deleted the feat/btc-e2e-tests branch July 16, 2024 09:24
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2024
@metamaskbot metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants