fix (cherry-pick): UX: Multichain: Add safeguard to throw error when confirmation chainId doesn't match current chainId (#25634) #25664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hainId doesn't match current chainId (#25634) ## **Description** This PR adds a safety rail to the confirmation screen such that an error is thrown if the user is seeing a confirmation for a transaction triggered on another chain. [](https://codespaces.new/MetaMask/metamask-extension/pull/25634?quickstart=1) ## **Related issues** Related: #25596 ## **Manual testing steps** 1. This state should be impossible to get to via the UI, thus no reasonable manual testing steps. Unit test included. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
darkwing
changed the title
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## Version-v12.0.0 #25664 +/- ##
================================================
Coverage 65.62% 65.62%
================================================
Files 1363 1363
Lines 54328 54330 +2
Branches 14122 14123 +1
================================================
+ Hits 35649 35651 +2
Misses 18679 18679 ☔ View full report in Codecov by Sentry. |
Builds ready [f655bd3]
Page Load Metrics (48 ± 4 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
@metamaskbot update-attributions |
## **Description** This fixes a crash of the transaction screen caused by the swap and smart transaction feature flag being incorrectly set. [](https://codespaces.new/MetaMask/metamask-extension/pull/25717?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Try sending a transaction with smart transaction enabled ## **Screenshots/Recordings** ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
darkwing
force-pushed
the
Version-v12.0.0.0-cherrypick-confirmation-safety
branch
from
4606af8
to
24c20a5
Compare
](https://codespaces.new/MetaMask/metamask-extension/pull/25634?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/25717?quickstart=1){kind=link}
metamaskbot
added
the
release-12.0.0
|
No release label on PR. Adding release label release-12.0.0 on PR, as PR was cherry-picked in branch 12.0.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a safety rail to the confirmation screen such that an error is thrown if the user is seeing a confirmation for a transaction triggered on another chain.
Related issues
Related: #25596
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Standards.
Pre-merge reviewer checklist
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist