fix (cherry-pick): UX: Multichain: Fix dead network problem when switching tabs (#25425) #25669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…5425) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> This PR ensures that a connection to a given network does not block the UI when switching to a dapp tab that remembers that down network, thus preventing a non-respondent network from not displaying the MetaMask UI [](https://codespaces.new/MetaMask/metamask-extension/pull/25425?quickstart=1) Fixes: #25588 1. Start local ganache 2. Add the local network to your network listing (Settings -> Networks -> Add custom network) 3. In tab 1, connect to dapp 1 on Localhost 4. In tab 2, connect to dapp 2 on Ethereum Mainnet 5. Kill local ganache 6. Click tab 1 7. Click the MetaMask icon in the extension bar 8. See UI pop up as expected 1. Start local ganache 2. Add the local network to your network listing (Settings -> Networks -> Add custom network) 3. In tab 1, connect to dapp 1 on Localhost 4. In tab 2, connect to dapp 2 on Ethereum Mainnet 5. Kill local ganache 6. Click tab 1 7. Trigger a transaction from the dapp 8. See UI pop up quickly, with confirmation, as expected <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> <!-- [screenshots/recordings] --> <!-- [screenshots/recordings] --> - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Mark Stacey <markjstacey@gmail.com>
darkwing
changed the title
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
](https://codespaces.new/MetaMask/metamask-extension/pull/25425?quickstart=1){kind=link}
metamaskbot
added
the
release-12.0.0
|
No release label on PR. Adding release label release-12.0.0 on PR, as PR was cherry-picked in branch 12.0.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Submitting as placeholder until previous cherry-picks are in, will rebase on that to fix merge conflict)
This PR ensures that a connection to a given network does not block the UI when switching to a dapp tab that remembers that down network, thus preventing a non-respondent network from not displaying the MetaMask UI
Fixes: #25588
Start local ganache
Add the local network to your network listing (Settings -> Networks -> Add custom network)
In tab 1, connect to dapp 1 on Localhost
In tab 2, connect to dapp 2 on Ethereum Mainnet
Kill local ganache
Click tab 1
Click the MetaMask icon in the extension bar
See UI pop up as expected
Start local ganache
Add the local network to your network listing (Settings -> Networks -> Add custom network)
In tab 1, connect to dapp 1 on Localhost
In tab 2, connect to dapp 2 on Ethereum Mainnet
Kill local ganache
Click tab 1
Trigger a transaction from the dapp
See UI pop up quickly, with confirmation, as expected
I've followed MetaMask Contributor Docs and MetaMask Extension Coding
Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist