README.md: fix CI badge #1239
Open
README.md: fix CI badge #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somehow, it was using the old format (with the workflow name and without the /actions/ subfolder in the path): https://github.com/MetacoSA/NBitcoin/actions/workflows/master.yml/badge.svg?branch=master&event=push And somehow, instead of generating a broken link, it was just showing always a red CI. But using the new badge format fixes this, which is explained here: https://docs.github.com/en/actions/monitoring-and-troubleshooting-workflows/monitoring-workflows/adding-a-workflow-status-badge Which says that it should rather have the workflow *filename* (not workflow name), and include the /actions/ subfolder in the path: https://github.com/MetacoSA/NBitcoin/actions/workflows/master.yml/badge.svg?branch=master&event=push
It's better that the workflow file name has the same name as the workflow name; and let's rather not use 'master' because that is the main branch name, and this workflow runs for any branch, not just this branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow, it was using the old format (with the workflow name
and without the /actions/ subfolder in the path):
And somehow, instead of generating a broken link, it was just
showing always a red CI.
But using the new badge format fixes this, which is explained
here:
https://docs.github.com/en/actions/monitoring-and-troubleshooting-workflows/monitoring-workflows/adding-a-workflow-status-badge
Which says that it should rather have the workflow filename
(not workflow name), and include the /actions/ subfolder in
the path: