Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Most models fail with error reason "file" #99

Open
watchful5406 opened this issue Apr 17, 2024 · 8 comments
Open

Most models fail with error reason "file" #99

watchful5406 opened this issue Apr 17, 2024 · 8 comments

Comments

@watchful5406
Copy link

On x86-64 branch of gmod
@Python1320
Copy link
Member

Do you have examples? New model https://steamcommunity.com/sharedfiles/filedetails/?id=3222720576 at least works for me.
Can you provide logs by setting outfitter_dbg 10 in console.

@Zvbhrf

This comment was marked as duplicate.

Sign in to view
@Zvbhrf
Copy link

Zvbhrf commented Jun 5, 2024 •
edited
Loading

It looks like the author won't respond anytime soon.

I opened the most popular tab and selected 3 models, but none of them worked.
Before doing that I verified my game files and joined a server with outfitter on x86-64

] lua_run_self print(BRANCH)
x86-64

First model

[Outfitter] doRefresh	nil
[Outfitter] Bodygroup	BTN	Refresh
[Outfitter] Bodygroup	BTN	Refresh
[Outfitter] Bodygroup	BTN	Refresh
[Outfitter] FetchWS	2691974423
[Outfitter] steamworks.FileInfo	2691974423	->	table: 0xe4993a7a
[Outfitter] 	title	Jerma985 Playermodel
[Outfitter] 	owner	76561198041874365
[Outfitter] 	tags	Addon,Model,movie,Cartoon,Comic
[Outfitter] 	size	456.22 KB
[Outfitter] 	fileid	0
[Outfitter] 	created ago	2 years
[Outfitter] DownloadUGC	2691974423	START
[Outfitter] Preload AlreadyMounted	2691974423	content/4000/2691974423/gmpublisher.gma	File	456.22 KB	ret=	true	false	lua/autorun/giwake_jerma.lua
[Outfitter] DownloadUGC	2691974423		result	content/4000/2691974423/gmpublisher.gma	File
[Outfitter] DownloadUGC	2691974423	returning	content/4000/2691974423/gmpublisher.gma	File	
[Outfitter] Download	2691974423	to	content/4000/2691974423/gmpublisher.gma	took	0.34350040000001
[Outfitter] FetchWS	downloading	2691974423	failed for reason:	file
[Outfitter] FetchWS downloading 2691974423 failed for reason: file
[Outfitter] UIChoseWorkshop	2691974423	FetchWS failed:	file	nil
[Outfitter] doRefresh	nil
[Outfitter] Bodygroup	BTN	Refresh
[Outfitter] Bodygroup	BTN	Refresh
[Outfitter] Bodygroup	BTN	Refresh
[Outfitter] Download failed for workshop 2691974423: file
[Outfitter ERROR] Download failed for workshop 2691974423: file

Second model

[Outfitter] FetchWS	3062759591
[Outfitter] steamworks.FileInfo	3062759591	->	table: 0xe6a84a6a
[Outfitter] 	title	Bird Citizen Playermodels + NPCs
[Outfitter] 	owner	76561198440487281
[Outfitter] 	tags	Addon,Model,Fun,Roleplay,Cartoon
[Outfitter] 	size	41.95 MB
[Outfitter] 	fileid	0
[Outfitter] 	created ago	31 weeks
[Outfitter] DownloadUGC	3062759591	START
[mysql-debug] Received	1	queries
UPDATE playertime SET playedtime = 26800041 WHERE steamid = 'STEAM_0:0:198601830';	87

[ONet] Received 	mysql-debug	 - 	true	(	802	)
[Outfitter] Preload AlreadyMounted	3062759591	content/4000/3062759591/gmpublisher.gma	File	41.95 MB	ret=	true	false	lua/birdman_sounds.lua
[Outfitter] DownloadUGC	3062759591		result	content/4000/3062759591/gmpublisher.gma	File
[Outfitter] DownloadUGC	3062759591	returning	content/4000/3062759591/gmpublisher.gma	File	
[Outfitter] Download	3062759591	to	content/4000/3062759591/gmpublisher.gma	took	4.5142752
[Outfitter] FetchWS	downloading	3062759591	failed for reason:	file
[Outfitter] FetchWS downloading 3062759591 failed for reason: file
[Outfitter] UIChoseWorkshop	3062759591	FetchWS failed:	file	nil
[Outfitter] doRefresh	nil
[Outfitter] Bodygroup	BTN	Refresh
[Outfitter] Bodygroup	BTN	Refresh
[Outfitter] Bodygroup	BTN	Refresh
[Outfitter] Download failed for workshop 3062759591: file
[Outfitter ERROR] Download failed for workshop 3062759591: file

Third model

[Outfitter] FetchWS	2787370699
[Outfitter] steamworks.FileInfo	2787370699	->	table: 0xf9ec8df2
[Outfitter] 	title	Walter White Playermodel
[Outfitter] 	owner	76561198117251209
[Outfitter] 	tags	Addon,Model,Roleplay,Realism,Cartoon
[Outfitter] 	size	20.06 MB
[Outfitter] 	fileid	0
[Outfitter] 	created ago	2 years
[Outfitter] DownloadUGC	2787370699	START
[Outfitter] Preload AlreadyMounted	2787370699	content/4000/2787370699/gmpublisher.gma	File	20.06 MB	ret=	true	false	lua/autorun/walterwhite_player.lua
[Outfitter] DownloadUGC	2787370699		result	content/4000/2787370699/gmpublisher.gma	File
[Outfitter] DownloadUGC	2787370699	returning	content/4000/2787370699/gmpublisher.gma	File	
[Outfitter] Download	2787370699	to	content/4000/2787370699/gmpublisher.gma	took	3.0472765
[Outfitter] FetchWS	downloading	2787370699	failed for reason:	file
[Outfitter] FetchWS downloading 2787370699 failed for reason: file
[Outfitter] UIChoseWorkshop	2787370699	FetchWS failed:	file	nil
[Outfitter] doRefresh	nil
[Outfitter] Bodygroup	BTN	Refresh
[Outfitter] Bodygroup	BTN	Refresh
[Outfitter] Bodygroup	BTN	Refresh
[Outfitter] Download failed for workshop 2787370699: file
[Outfitter ERROR] Download failed for workshop 2787370699: file

@Zvbhrf
Copy link

Zvbhrf commented Jun 5, 2024

outfitter/lua/outfitter/cows.lua

Line 294 in cdf1e9a

if not IsUGCFilePath(path) and file.Size(path,'MOD')<=512 then

path leads outside of gmod folder?

image
image

It may be related to this, but I'm not sure
image

@Cynosphere
Copy link
Member

IsUGCFilePath shouldn't be returning false. Either you're on an outdated version that doesn't have the updated function or another addon is breaking string.find

It may be related to this, but I'm not sure

That is for legacy addons and is irrelevant to Outfitter.

@Zvbhrf
Copy link

Zvbhrf commented Jun 6, 2024

Ok, I'll check

@Python1320
Copy link
Member

Maybe I forgot to update workshop version? I'll have a look soonish...

@Zvbhrf
Copy link

Zvbhrf commented Aug 20, 2024

I apologize for the long delay and the concern, but it seems like it's still relevant because people on my server are still complaining about it.
Is there any info about this issue?

(also #102)

2 tests

[Outfitter] OnPlayerVisible	IsEnabled	Player [5][Hohich]
[Outfitter] doRefresh	nil
[Outfitter] Bodygroup	BTN	Refresh
[Outfitter] Bodygroup	BTN	Refresh
[Outfitter] Bodygroup	BTN	Refresh
[Outfitter] OnPlayerVisible	IsEnabled	Player [5][Hohich]
[Outfitter] WantOutfitMDL		2787370699	models/walterwhite/playermodels/walterwhitechem.mdl	Walter White Playermodel
[Outfitter] WantOutfitMDL	ALREADY WANTING	2787370699	models/walterwhite/playermodels/walterwhitechem.mdl	Walter White Playermodel
[Outfitter] FetchWS	2787370699
[Outfitter] steamworks.FileInfo	2787370699	->	table: 0xfabc8d22
[Outfitter] 	title	Walter White Playermodel
[Outfitter] 	owner	76561198117251209
[Outfitter] 	tags	Addon,Model,Roleplay,Realism,Cartoon
[Outfitter] 	size	20.06 MB
[Outfitter] 	fileid	0
[Outfitter] 	created ago	2 years
[Outfitter] DownloadUGC	2787370699	START
[Outfitter] OnPlayerVisible	IsEnabled	Player [5][Hohich]
[Outfitter] OnPlayerVisible	IsEnabled	Player [5][Hohich]
[Outfitter] OnPlayerVisible	IsEnabled	Player [5][Hohich]
[Outfitter] OnPlayerVisible	IsEnabled	Player [5][Hohich]
[Outfitter] OnPlayerVisible	IsEnabled	Player [5][Hohich]
[Outfitter] Preload AlreadyMounted	2787370699	content/4000/2787370699/gmpublisher.gma	File	20.06 MB	ret=	true	false	lua/autorun/walterwhite_player.lua
[Outfitter] DownloadUGC	2787370699		result	content/4000/2787370699/gmpublisher.gma	File
[Outfitter] DownloadUGC	2787370699	returning	content/4000/2787370699/gmpublisher.gma	File	
[Outfitter] Download	2787370699	to	content/4000/2787370699/gmpublisher.gma	took	4.7765826999985
[Outfitter] FetchWS	downloading	2787370699	failed for reason:	file
[Outfitter] FetchWS downloading 2787370699 failed for reason: file
* FetchWS downloading 2787370699 failed for reason: file
[Outfitter] UIChoseWorkshop	2787370699	FetchWS failed:	file	nil
[Outfitter] Download failed for workshop 2787370699: file
* Download failed for workshop 2787370699: file
[Outfitter ERROR] Download failed for workshop 2787370699: file
[Outfitter] doRefresh	models/walterwhite/playermodels/walterwhitechem.mdl
[Outfitter] Bodygroup	BTN	Refresh
[Outfitter] Bodygroup	BTN	Refresh
[Outfitter] Bodygroup	BTN	Refresh
[Outfitter] OnPlayerVisible	IsEnabled	Player [5][Hohich]
[Outfitter] NetData	Player [5][Hohich]	OF	<-	["models/nseven/the_brain.mdl","824931326"]
[Outfitter] OnPlayerVisible	IsEnabled	Player [5][Hohich]
[Outfitter] OnPlayerVisible	IsEnabled	Player [5][Hohich]
[Outfitter] OnPlayerVisible	IsEnabled	Player [5][Hohich]

[Outfitter] OnPlayerVisible	IsEnabled	Player [5][Hohich]
[Outfitter] doRefresh	nil
[Outfitter] Bodygroup	BTN	Refresh
[Outfitter] Bodygroup	BTN	Refresh
[Outfitter] Bodygroup	BTN	Refresh
[Outfitter] WantOutfitMDL		2691974423	models/player/giwake/jermaregular.mdl	Jerma985 Playermodel
[Outfitter] WantOutfitMDL	ALREADY WANTING	2691974423	models/player/giwake/jermaregular.mdl	Jerma985 Playermodel
[Outfitter] FetchWS	2691974423
[Outfitter] steamworks.FileInfo	2691974423	->	table: 0x879faaa2
[Outfitter] 	title	Jerma985 Playermodel
[Outfitter] 	owner	76561198041874365
[Outfitter] 	tags	Addon,Model,movie,Cartoon,Comic
[Outfitter] 	size	456.22 KB
[Outfitter] 	fileid	0
[Outfitter] 	created ago	2 years
[Outfitter] DownloadUGC	2691974423	START
[Outfitter] Preload AlreadyMounted	2691974423	content/4000/2691974423/gmpublisher.gma	File	456.22 KB	ret=	true	false	lua/autorun/giwake_jerma.lua
[Outfitter] DownloadUGC	2691974423		result	content/4000/2691974423/gmpublisher.gma	File
[Outfitter] DownloadUGC	2691974423	returning	content/4000/2691974423/gmpublisher.gma	File	
[Outfitter] Download	2691974423	to	content/4000/2691974423/gmpublisher.gma	took	2.5883952000004
[Outfitter] FetchWS	downloading	2691974423	failed for reason:	file
[Outfitter] FetchWS downloading 2691974423 failed for reason: file
* FetchWS downloading 2691974423 failed for reason: file
[Outfitter] UIChoseWorkshop	2691974423	FetchWS failed:	file	nil
[Outfitter] Download failed for workshop 2691974423: file
* Download failed for workshop 2691974423: file
[Outfitter ERROR] Download failed for workshop 2691974423: file
[Outfitter] doRefresh	models/player/giwake/jermaregular.mdl
[Outfitter] Bodygroup	BTN	Refresh
[Outfitter] Bodygroup	BTN	Refresh
[Outfitter] Bodygroup	BTN	Refresh

New model https://steamcommunity.com/sharedfiles/filedetails/?id=3222720576 at least works for me.
Doesn't work now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Python1320 @Cynosphere @Zvbhrf @watchful5406