Skip to content

Commit

Permalink
Merge pull request #117 from MetroStar/unlighthouse-fix
Browse files Browse the repository at this point in the history
Unlighthouse Accessibility Fix
  • Loading branch information
jbouder authored Mar 5, 2024
2 parents d157ae0 + 9bad3c5 commit 29924a2
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/accessibility-testing.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,4 @@ jobs:
run: npm install -g @unlighthouse/cli puppeteer

- name: Run Tests
run: unlighthouse-ci --config unlighthouse.config.ts --build-static --reporter jsonExpanded
run: unlighthouse-ci --config-file unlighthouse.config.ts --build-static --reporter jsonExpanded --debug
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"e2e:ci:run": "rm cypress/reports/* || true && npx cypress run --reporter mochawesome",
"e2e:ci:report": "mochawesome-merge cypress/reports/*.json > cypress/reports/report.json && marge --reportDir cypress/reports cypress/reports/report.json",
"e2e:format": "npx prettier cypress --write",
"a11y": "unlighthouse --config unlighthouse.config.ts",
"a11y": "unlighthouse --config-file unlighthouse.config.ts",
"prepare": "husky install",
"predeploy": "vite build --base=/comet-starter/",
"deploy": "gh-pages -d dist"
Expand Down Expand Up @@ -96,7 +96,6 @@
"@rollup/rollup-linux-x64-gnu": "4.12.0"
},
"overrides": {
"ip": "2.0.1",
"xml2js": "0.6.2"
}
}
6 changes: 4 additions & 2 deletions unlighthouse.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { defineConfig } from 'unlighthouse';
export default defineConfig({
ci: {
budget: {
performance: 90,
performance: 80,
accessibility: 90,
'best-practices': 90,
seo: 90,
Expand Down Expand Up @@ -32,9 +32,11 @@ export default defineConfig({
// headless: false,
// slowMo: 50,
},
routerPrefix: '/comet-starter',
scanner: {
device: 'desktop',
skipJavascript: false,
},
site: 'https://metrostar.github.io/comet-starter/',
site: 'https://metrostar.github.io',
urls: ['/comet-starter'],
});

0 comments on commit 29924a2

Please sign in to comment.