Feat/czech exchange rate #643
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team, this PR contains the changes requested for the Czech exchange rate provider.
I have kept the currency, exchange rate and exchange rate provider contracts the same.
The project has been updated to use the default host builder implementation which encapsulates DI and config.
I have then moved the static currency array into configuration.
I have also added some resiliency to the Czech bank call with a transient error retry policy.
My assumption with this project was to keep it light.
I could see this being used from a CRON job and then push out to a topic or queue to notify sub system components.
I would also consider an opportunity for this to be a small azure function.
Please let me know what you think :).