Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [DX-2198] Migrate stories to widgetbook #682

Merged
merged 7 commits into from
Sep 25, 2024
Merged

feat: [DX-2198] Migrate stories to widgetbook #682

merged 7 commits into from
Sep 25, 2024

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Sep 16, 2024

Summary

  • migrated storied to widgetbook

Testing steps

They are not needed. This is a migration to the widgetbook. Follow-ups will fix each story after the initial migration.

Follow-up issues

Fixes after the migration.
Publish new storybook, based on the widgetbook

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

Copy link
Contributor

⛔ PR has more than 500 additions. Split it into smaller PRs.

@witwash witwash added the ignore-size Ignore the size of this PR label Sep 23, 2024
@witwash witwash marked this pull request as ready for review September 23, 2024 07:01
@witwash witwash requested a review from a team as a code owner September 23, 2024 07:01
@witwash
Copy link
Contributor Author

witwash commented Sep 23, 2024

Most of it is 1:1 with old stories but wrapped in widgetbook helpers etc.

@witwash
Copy link
Contributor Author

witwash commented Sep 23, 2024

You can check it out here https://optimus-widgetbook.web.app/

@witwash witwash merged commit 965d5ba into master Sep 25, 2024
6 checks passed
@witwash witwash deleted the DX-2198 branch September 25, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-size Ignore the size of this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants