Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: [DX-2254] Setup publish action for widgetbook #687

Merged
merged 2 commits into from
Sep 30, 2024
Merged

build: [DX-2254] Setup publish action for widgetbook #687

merged 2 commits into from
Sep 30, 2024

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Sep 25, 2024 •
edited
Loading

Summary

  • code rearrangements needed for Firebase publish
  • changed publish action to now publish widgetbook folder instead of the old storybook

Testing steps

  • run action manually after RP gets merged

Follow-up issues

  • remove old storybook

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash marked this pull request as ready for review September 25, 2024 10:54
@witwash witwash requested a review from a team as a code owner September 25, 2024 10:54
@witwash witwash merged commit d91ca98 into master Sep 30, 2024
6 checks passed
@witwash witwash deleted the DX-2254 branch September 30, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaeMil chaeMil chaeMil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@witwash @chaeMil