Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: [DX-2275] Update list knobs #692

Merged
merged 4 commits into from
Oct 14, 2024
Merged

refactor: [DX-2275] Update list knobs #692

merged 4 commits into from
Oct 14, 2024

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Oct 2, 2024 •
edited
Loading

Summary

  • added extensions for some common knobs
  • added labelBuilder for the list for better usability
  • removed duplicated useCase

Testing steps

None. Dev-tested.

Follow-up issues

None.

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash added the ignore-size Ignore the size of this PR label Oct 3, 2024
@witwash witwash marked this pull request as ready for review October 3, 2024 13:12
@witwash witwash requested a review from a team as a code owner October 3, 2024 13:12
@witwash witwash marked this pull request as draft October 3, 2024 14:22
@witwash witwash marked this pull request as ready for review October 4, 2024 10:37
@witwash
Copy link
Contributor Author

witwash commented Oct 4, 2024

@chaeMil, ready

@witwash
Copy link
Contributor Author

witwash commented Oct 14, 2024

@chaeMil, ping

@witwash witwash merged commit 9ddd5f9 into master Oct 14, 2024
8 checks passed
@witwash witwash deleted the DX-2275 branch October 14, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaeMil chaeMil chaeMil approved these changes

Assignees
No one assigned
Labels
ignore-size Ignore the size of this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@witwash @chaeMil