Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [DX-2199] Fix alignment addon #693

Merged
merged 1 commit into from
Oct 14, 2024
Merged

fix: [DX-2199] Fix alignment addon #693

merged 1 commit into from
Oct 14, 2024

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Oct 3, 2024

Summary

  • Fixed AlignmentAddon not working properly because of the wrong order in nesting.

Testing steps

  • AlignmentAddon should work now and change align should visually change the position of the showcased component.

Follow-up issues

  • Rework some use cases that wrap components in Center as they would intervene with this addon.

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash marked this pull request as ready for review October 3, 2024 19:06
@witwash witwash requested a review from a team as a code owner October 3, 2024 19:06
@witwash witwash enabled auto-merge (squash) October 4, 2024 08:55
@witwash
Copy link
Contributor Author

witwash commented Oct 14, 2024

@chaeMil, ping

@witwash witwash merged commit f3b1561 into master Oct 14, 2024
7 checks passed
@witwash witwash deleted the DX-2199 branch October 14, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants