feat!: [DX-3266] Upgrade to DCM 1.23

[witwash]

Summary

• upgraded to 1.23.1
• added new rules
• fixed linter issues

Enabled rules

Common:

• prefer-simpler-boolean-expressions
• avoid-late-final-reassignment
• avoid-referencing-subclasses
• use-existing-variable
• avoid-complex-loop-conditions

Rules left disabled

• avoid-high-cyclomatic-complexity
• avoid-non-empty-constructor-bodies

Bloc:

• avoid-empty-build-when

Testing steps

None

Follow-up issues

Publish

Check during review

• Verify against Jira issue.
• Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
• Unused code removed.
• Build passing.
• Is it a bug fix? Check that it is covered by a proper test (unit or integration).

[ookami-kb]

I would disable the rules:

• avoid-empty-build-when – for me, it's usually the other way around – having to specify buildWhen is often a sign of bloated BLoC that does too many things and keeps too much of state.
• avoid-high-cyclomatic-complexity – I'm always sceptic about this artificial numbers. The length and complexity of the method should be driven by it's logic, not vice versa. Often, when you start blindly following the rules like "forbid functions with >20 LOC", it leads to worse code, where you break functions into sub-functions to please the analyzer, and you end up with a bunch of small functions and lack of overall clear flow.