Use minimal gnupg #555
Closed
Use minimal gnupg #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why the tests fail though... |
Mic92
reviewed
May 9, 2024
| @@ -320,7 +320,7 @@ in { | |||
| }]) cfg.secrets) | |||
| ); | |||
|
|
|||
| sops.environment.SOPS_GPG_EXEC = lib.mkIf (cfg.gnupg.home != null || cfg.gnupg.sshKeyPaths != []) (lib.mkDefault "${pkgs.gnupg}/bin/gpg"); | |||
| sops.environment.SOPS_GPG_EXEC = lib.mkIf (cfg.gnupg.home != null || cfg.gnupg.sshKeyPaths != []) (lib.mkDefault (lib.getExe (pkgs.gnupg.override { enableMinimal = true; }))); | |||
There was a problem hiding this comment.
Do we cache the minimal build in hydra?
There was a problem hiding this comment.
Kinda https://github.com/NixOS/nixpkgs/blob/e4c22dc16b36c17bea471ecc3ae616f64e69d3d2/pkgs/top-level/all-packages.nix#L27888-L27891, should I do a PR to promote that to a top-level attr?
The closure size of the minimal gnupg is significant smaller.
normal gnupg minimal gnupg
➜ nix path-info --size --closure-size --human-readable /nix/store/5kk1414f5iadlz9b7vnbg5dlk6icryjl-gnupg-2.4.5/ /nix/store/xp9bd1qyw5bdhshxmd1bdlhbi5hwdxwy-gnupg-2.4.5
/nix/store/5kk1414f5iadlz9b7vnbg5dlk6icryjl-gnupg-2.4.5 12.8M 133.5M
/nix/store/xp9bd1qyw5bdhshxmd1bdlhbi5hwdxwy-gnupg-2.4.5 1.2M 34.4M
SuperSandro2000
force-pushed
the
minimal-gnupg
branch
from
cedef7a
to
4d7a3a4
Compare
|
The tests are failing because the minimal gnupg is so barebones, that it cannot initialize from an empty installation. I give up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The closure size of the minimal gnupg is significant smaller.