Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to R6 for streaming #151

Merged
merged 20 commits into from
Nov 7, 2023
Merged

Revert to R6 for streaming #151

merged 20 commits into from
Nov 7, 2023

Conversation

calderonsamuel
Copy link
Collaborator

Right now this is just a placeholder for the job. I wasn't able to find the time before (because of the LatinR conference), but I'll have some free time this and next week that should allow me to get this done. Sorry for the delay!

@calderonsamuel calderonsamuel changed the title Revert to R6 Revert to R6 for streaming Oct 24, 2023
@calderonsamuel
Copy link
Collaborator Author

Good news @JamesHWade

At this point he have a working StreamHandler inside gptstudio_request_perform(). We are no longer writing and reading streams from disk! 🥳

So far I have encountered two problems:

  1. We always need to click the settings button to not get them as NULL. I believe this is because it is rendered as a ModalDialog.
  2. The user message gets recorded twice in the chat history. This of course renders it twice each time in the chat windows. (should be easy to fix)
  3. The stream is still inconsistent, and sometimes breaks in the middle of a response. Once 1 and 2 are fixed it should be enough to merged this PR and ask users to try to break it.

I also think there are some things to improve in the skeleton building process, but that will become a separate issue

@calderonsamuel calderonsamuel marked this pull request as ready for review November 2, 2023 15:45
@calderonsamuel
Copy link
Collaborator Author

All ready to merge

fix #143 , fix #148

@JamesHWade
Copy link
Collaborator

Sorry for the delay, @calderonsamuel. My wife gave birth to twins last month, so I have been a bit preoccupied. Thank you for this fantastic contribution, as usual.

@JamesHWade JamesHWade merged commit 2ff2a0b into MichelNivard:main Nov 7, 2023
9 checks passed
@calderonsamuel calderonsamuel deleted the R6 branch November 7, 2023 16:13
@calderonsamuel
Copy link
Collaborator Author

Sorry for the delay, @calderonsamuel. My wife gave birth to twins last month, so I have been a bit preoccupied. Thank you for this fantastic contribution, as usual.

Don't worry. Congratulations to you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants