Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Set-SPORestrictedSiteCreation.md #757

Merged
merged 10 commits into from
Dec 9, 2024

Conversation

vgaddam-pm
Copy link
Contributor

@vgaddam-pm vgaddam-pm commented Nov 15, 2024

PubOps PR review

New Cmdlet for new RSC feature releasing at Ignite

New Cmdlet for new RSC feature releasing at Ignite
Copy link
Contributor

Learn Build status updates of commit d3bd9b5:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details
sharepoint/docs-conceptual/sharepoint-server/sharepoint-server-cmdlets.md ⚠️Warning Details
sharepoint/docs-conceptual/sharepoint-server/sharepoint-server-sub-cmdlets.md ⚠️Warning Details

  • Line 0, Column 0: [Error: MAML2Yaml_Uid_Duplicated] Duplicate uid found: sharepoint-ps/sharepoint-online/Set-SPOSite.md and sharepoint-ps/sharepoint-online/Set-SPORestrictedSiteCreation.md has the same uid: Microsoft.Online.SharePoint.PowerShell.Set-SPOSite.

sharepoint/docs-conceptual/sharepoint-server/sharepoint-server-cmdlets.md

  • Line 2, Column 8: [Warning: duplicate-titles - See documentation] Title 'SharePoint Server Cmdlets' is duplicated in: 'docs-conceptual/sharepoint-server/sharepoint-server-cmdlets.md(2,8), docs-conceptual/sharepoint-server/sharepoint-server-sub-cmdlets.md(2,8)'. Titles must be unique within a docset.
  • Line 6, Column 1: [Warning: duplicate-h1s - See documentation] H1 'SharePoint Server Cmdlets' is duplicated with other articles: 'docs-conceptual/sharepoint-server/sharepoint-server-cmdlets.md(6,1), docs-conceptual/sharepoint-server/sharepoint-server-sub-cmdlets.md(6,1)'. First level headings must be unique within a docset.
  • Line 8, Column 53: [Warning: xref-not-found - See documentation] Cross reference not found: 'SharePointServer'.
  • Line 31, Column 62: [Warning: xref-not-found - See documentation] Cross reference not found: 'SharePointServer.Add-SPShellAdmin'.
  • Line 2, Column 1: [Suggestion: manager-missing - See documentation] Missing required attribute: 'manager'. Add a valid Microsoft alias for the author's manager.
  • Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

sharepoint/docs-conceptual/sharepoint-server/sharepoint-server-sub-cmdlets.md

  • Line 2, Column 8: [Warning: duplicate-titles - See documentation] Title 'SharePoint Server Cmdlets' is duplicated in: 'docs-conceptual/sharepoint-server/sharepoint-server-cmdlets.md(2,8), docs-conceptual/sharepoint-server/sharepoint-server-sub-cmdlets.md(2,8)'. Titles must be unique within a docset.
  • Line 6, Column 1: [Warning: duplicate-h1s - See documentation] H1 'SharePoint Server Cmdlets' is duplicated with other articles: 'docs-conceptual/sharepoint-server/sharepoint-server-cmdlets.md(6,1), docs-conceptual/sharepoint-server/sharepoint-server-sub-cmdlets.md(6,1)'. First level headings must be unique within a docset.
  • Line 8, Column 53: [Warning: xref-not-found - See documentation] Cross reference not found: 'SharePointServer'.
  • Line 31, Column 62: [Warning: xref-not-found - See documentation] Cross reference not found: 'SharePointServer.Add-SPShellAdmin'.
  • Line 2, Column 1: [Suggestion: manager-missing - See documentation] Missing required attribute: 'manager'. Add a valid Microsoft alias for the author's manager.
  • Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@vgaddam-pm
Copy link
Contributor Author

@vgaddam-pm please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

@vgaddam-pm vgaddam-pm closed this Nov 15, 2024
@vgaddam-pm vgaddam-pm reopened this Nov 15, 2024
Copy link
Contributor

Learn Build status updates of commit d3bd9b5:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details
sharepoint/docs-conceptual/sharepoint-server/sharepoint-server-cmdlets.md ⚠️Warning Details
sharepoint/docs-conceptual/sharepoint-server/sharepoint-server-sub-cmdlets.md ⚠️Warning Details

  • Line 0, Column 0: [Error: MAML2Yaml_Uid_Duplicated] Duplicate uid found: sharepoint-ps/sharepoint-online/Set-SPOSite.md and sharepoint-ps/sharepoint-online/Set-SPORestrictedSiteCreation.md has the same uid: Microsoft.Online.SharePoint.PowerShell.Set-SPOSite.

sharepoint/docs-conceptual/sharepoint-server/sharepoint-server-cmdlets.md

  • Line 2, Column 8: [Warning: duplicate-titles - See documentation] Title 'SharePoint Server Cmdlets' is duplicated in: 'docs-conceptual/sharepoint-server/sharepoint-server-cmdlets.md(2,8), docs-conceptual/sharepoint-server/sharepoint-server-sub-cmdlets.md(2,8)'. Titles must be unique within a docset.
  • Line 6, Column 1: [Warning: duplicate-h1s - See documentation] H1 'SharePoint Server Cmdlets' is duplicated with other articles: 'docs-conceptual/sharepoint-server/sharepoint-server-cmdlets.md(6,1), docs-conceptual/sharepoint-server/sharepoint-server-sub-cmdlets.md(6,1)'. First level headings must be unique within a docset.
  • Line 8, Column 53: [Warning: xref-not-found - See documentation] Cross reference not found: 'SharePointServer'.
  • Line 31, Column 62: [Warning: xref-not-found - See documentation] Cross reference not found: 'SharePointServer.Add-SPShellAdmin'.
  • Line 2, Column 1: [Suggestion: manager-missing - See documentation] Missing required attribute: 'manager'. Add a valid Microsoft alias for the author's manager.
  • Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

sharepoint/docs-conceptual/sharepoint-server/sharepoint-server-sub-cmdlets.md

  • Line 2, Column 8: [Warning: duplicate-titles - See documentation] Title 'SharePoint Server Cmdlets' is duplicated in: 'docs-conceptual/sharepoint-server/sharepoint-server-cmdlets.md(2,8), docs-conceptual/sharepoint-server/sharepoint-server-sub-cmdlets.md(2,8)'. Titles must be unique within a docset.
  • Line 6, Column 1: [Warning: duplicate-h1s - See documentation] H1 'SharePoint Server Cmdlets' is duplicated with other articles: 'docs-conceptual/sharepoint-server/sharepoint-server-cmdlets.md(6,1), docs-conceptual/sharepoint-server/sharepoint-server-sub-cmdlets.md(6,1)'. First level headings must be unique within a docset.
  • Line 8, Column 53: [Warning: xref-not-found - See documentation] Cross reference not found: 'SharePointServer'.
  • Line 31, Column 62: [Warning: xref-not-found - See documentation] Cross reference not found: 'SharePointServer.Add-SPShellAdmin'.
  • Line 2, Column 1: [Suggestion: manager-missing - See documentation] Missing required attribute: 'manager'. Add a valid Microsoft alias for the author's manager.
  • Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit e55e685:

⚠️ Validation status: warnings

File Status Preview URL Details
sharepoint/sharepoint-ps/sharepoint-online/Set-SPORestrictedSiteCreation.md ⚠️Warning View (sharepoint-ps) Details

sharepoint/sharepoint-ps/sharepoint-online/Set-SPORestrictedSiteCreation.md

  • Line 0, Column 0: [Warning: author-not-found - See documentation] Invalid value for author: 'vaibhav-gaddam' is not a valid GitHub ID.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 9a7f6da:

⚠️ Validation status: warnings

File Status Preview URL Details
sharepoint/sharepoint-ps/sharepoint-online/Set-SPORestrictedSiteCreation.md ⚠️Warning View (sharepoint-ps) Details

sharepoint/sharepoint-ps/sharepoint-online/Set-SPORestrictedSiteCreation.md

  • Line 0, Column 0: [Warning: author-not-found - See documentation] Invalid value for author: 'vaibhav-gaddam' is not a valid GitHub ID.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 1d87ef5:

✅ Validation status: passed

File Status Preview URL Details
sharepoint/sharepoint-ps/sharepoint-online/Set-SPORestrictedSiteCreation.md ✅Succeeded View (sharepoint-ps)

For more details, please refer to the build report.

For any questions, please:


## DESCRIPTION

The Set-SPORestrictedSiteCreation cmdlet sets or updates the configuration or setting for the Restricted Site Creation feature.
Copy link
Contributor

@samkabue samkabue Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Set-SPORestrictedSiteCreation

"This cmdlet" #Closed


The Set-SPORestrictedSiteCreation cmdlet sets or updates the configuration or setting for the Restricted Site Creation feature.

You must be a SharePoint Online administrator to run the cmdlet.
Copy link
Contributor

@samkabue samkabue Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line -- we only include it if it requires a different permission other than SharePoint admin, since by definition cmdlets can only be executed by SharePoint admin #Closed

You must be a SharePoint Online administrator to run the cmdlet.

For permissions and the most current information about Windows PowerShell for SharePoint Online, see the online documentation at [Intro to SharePoint Online Management Shell](https://learn.microsoft.com/powershell/sharepoint/sharepoint-online/introduction-sharepoint-online-management-shell?view=sharepoint-ps).

Copy link
Contributor

@samkabue samkabue Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line, move it to the bottom of page as a related link:

[Intro to SharePoint Online Management Shell](/powershell/sharepoint/sharepoint-online/introduction-sharepoint-online-management-shell)
``` #Closed


> [!Important]
> You must use version 16.0.25513 (published November 2024) or later of the [SharePoint Online Management Shell](https://www.microsoft.com/en-us/download/details.aspx?id=35588) for these commands to function properly. Earlier versions do not have the current list of site types and will not operate correctly.

Copy link
Contributor

@samkabue samkabue Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this -- it's not useful. admins know that if they can't find a cmdlet they know to upgrade to a later build #Closed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sam, this is the issue I believe Matthew Calligaro talked to you about. the Cmdlet will be available at a prior build but won't function properly because the enum mapping will change with OneDrive support

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we also don't know yet what exactly the November build will be. 25513 is a good guess for now based on the fork date, but these numbers have changed in the past, e.g., by PM deciding to pick up a later build.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing this out, will keep this in mind.

Set-SPORestrictedSiteCreation –Enabled:$true
```

Example 1`enables the restricted site creation feature for the tenant.
Copy link
Contributor

@samkabue samkabue Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

`

remove this backtick #Closed

Set-SPORestrictedSiteCreation –Enabled:$true
```

Example 1`enables the restricted site creation feature for the tenant.
Copy link
Contributor

@samkabue samkabue Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

`

add blank line above #Closed

### Example 5

```powershell
Set-SPORestrictedSiteCreation –SiteType "OneDrive" -RestrictedSiteCreationGroups "" ```
Copy link
Contributor

@samkabue samkabue Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move these backticks to the next line #Closed

### -Enabled

PARAMVALUE: true | false
Enables of disabled Restricted Site Creation feature in tenant
Copy link
Contributor

@samkabue samkabue Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enables of

fix grammer #Closed

### -Enabled

PARAMVALUE: true | false
Enables of disabled Restricted Site Creation feature in tenant
Copy link
Contributor

@samkabue samkabue Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tenant

make sure all sentences end with a . #Closed


### -SiteType

When paired with the –RestrictedSiteCreationGroups parameter, creates a new policy which applies to the specified types of sites.
Copy link
Contributor

@samkabue samkabue Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

–RestrictedSiteCreationGroups

add backticks to this param #Closed


### -RestrictedSiteCreationGroups

A comma-separated list of up to 10 Microsoft Entra security group IDs. When paired with the –SiteType parameter, defines a new policy which applies to the specified groups.
Copy link
Contributor

@samkabue samkabue Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

–SiteType

add backticks to this param #Closed


## RELATED LINKS

[Getting started with SharePoint Online Management Shell](https://learn.microsoft.com/powershell/sharepoint/sharepoint-online/connect-sharepoint-online?view=sharepoint-ps)
Copy link
Contributor

@samkabue samkabue Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://learn.microsoft.com/powershell/sharepoint/sharepoint-online/connect-sharepoint-online?view=sharepoint-ps

use relative link

/powershell/sharepoint/sharepoint-online/connect-sharepoint-online
``` #Closed

@samkabue samkabue added the Back to submitter The pull request didn't pass the review criteria and has been returned to the writer for updates label Nov 15, 2024
Copy link
Contributor

@samkabue samkabue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

Updating document according to Sam Kabue's comments.
Copy link
Contributor

Learn Build status updates of commit bb5b103:

✅ Validation status: passed

File Status Preview URL Details
sharepoint/sharepoint-ps/sharepoint-online/Set-SPORestrictedSiteCreation.md ✅Succeeded View (sharepoint-ps)

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 1ad2dc1:

✅ Validation status: passed

File Status Preview URL Details
sharepoint/sharepoint-ps/sharepoint-online/Set-SPORestrictedSiteCreation.md ✅Succeeded View (sharepoint-ps)

For more details, please refer to the build report.

For any questions, please:

@vgaddam-pm vgaddam-pm requested a review from samkabue November 16, 2024 00:01
@vgaddam-pm vgaddam-pm marked this pull request as draft November 19, 2024 23:16
@vgaddam-pm vgaddam-pm marked this pull request as ready for review November 19, 2024 23:17
Copy link
Contributor

Learn Build status updates of commit d046156:

✅ Validation status: passed

File Status Preview URL Details
sharepoint/sharepoint-ps/sharepoint-online/Set-SPORestrictedSiteCreation.md ✅Succeeded View (sharepoint-ps)

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 478c524:

✅ Validation status: passed

File Status Preview URL Details
sharepoint/sharepoint-ps/sharepoint-online/Set-SPORestrictedSiteCreation.md ✅Succeeded View (sharepoint-ps)

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 9398abc:

✅ Validation status: passed

File Status Preview URL Details
sharepoint/sharepoint-ps/sharepoint-online/Set-SPORestrictedSiteCreation.md ✅Succeeded View (sharepoint-ps)

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

@samkabue samkabue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@samkabue samkabue added Sign off The pull request is ready to be reviewed and merged by PubOps and removed Back to submitter The pull request didn't pass the review criteria and has been returned to the writer for updates labels Dec 5, 2024
@Stacyrch140 Stacyrch140 self-assigned this Dec 5, 2024
@Stacyrch140 Stacyrch140 added the In review PubOps is reviewing the pull request label Dec 5, 2024
@Stacyrch140
Copy link
Contributor

Hi @vgaddam-pm -

Following are blocking issues that need to be resolved before we can merge:

sharepoint/sharepoint-ps/sharepoint-online/Set-SPORestrictedSiteCreation.md

  • Add this file to a relevant TOC, and include the TOC with this PR.

Reference

Criteria used for pull request reviews

Blocking

  • When a new article is added, the same PR must also contain at least one updated TOC with an entry for the new article. Exceptions are allowed when the file has ROBOTS: NOINDEX, NOFOLLOW in the metadata.

After you resolve the blocking issues, remove the Back to submitter label and add the Sign off label again.

If you need help resolving issues in this PR, post your question in the Ask an Admin Teams Channel.

Thanks,
Stacy

@Stacyrch140 Stacyrch140 added Back to submitter The pull request didn't pass the review criteria and has been returned to the writer for updates and removed In review PubOps is reviewing the pull request Sign off The pull request is ready to be reviewed and merged by PubOps labels Dec 5, 2024
Copy link
Contributor

Learn Build status updates of commit d22c638:

✅ Validation status: passed

File Status Preview URL Details
sharepoint/sharepoint-ps/sharepoint-online/Set-SPORestrictedSiteCreation.md ✅Succeeded View (sharepoint-ps)
sharepoint/sharepoint-ps/sharepoint-online/sharepoint-online.md ✅Succeeded View (sharepoint-ps)

For more details, please refer to the build report.

For any questions, please:

@vgaddam-pm vgaddam-pm requested a review from samkabue December 5, 2024 19:17
@vgaddam-pm
Copy link
Contributor Author

@Stacyrch140 to review now. Have added to TOC but cannot assign labels myself.

@samkabue samkabue added Sign off The pull request is ready to be reviewed and merged by PubOps and removed Back to submitter The pull request didn't pass the review criteria and has been returned to the writer for updates labels Dec 9, 2024
@rjagiewich rjagiewich added the In review PubOps is reviewing the pull request label Dec 9, 2024
@rjagiewich rjagiewich self-assigned this Dec 9, 2024
@rjagiewich rjagiewich merged commit 431e92d into MicrosoftDocs:main Dec 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In review PubOps is reviewing the pull request Microsoft submitter Sign off The pull request is ready to be reviewed and merged by PubOps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants