Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Get-SPORestrictedSiteCreation #759

Merged
merged 9 commits into from
Dec 9, 2024

Conversation

vgaddam-pm
Copy link
Contributor

@vgaddam-pm vgaddam-pm commented Nov 15, 2024

PubOps PR review

Adding Get-SPORestrictedSiteCreation Cmdlet for Restricted Site Creation Feature.

Adding Get-SPORestrictedSiteCreation Cmdlet for Restricted Site Creation Feature.
Copy link
Contributor

Learn Build status updates of commit c603121:

✅ Validation status: passed

File Status Preview URL Details
sharepoint/sharepoint-ps/sharepoint-online/Get-SPORestrictedSiteCreation ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@samkabue
Copy link
Contributor

samkabue commented Nov 15, 2024

your file needs to have extension ".md" -- so Get-SPORestrictedSiteCreation.md #Closed

@samkabue samkabue added the Back to submitter The pull request didn't pass the review criteria and has been returned to the writer for updates label Nov 15, 2024
Copy link
Contributor

@samkabue samkabue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐


```powershell
Get-SPORestrictedSiteCreation
[-SiteType <RestrictedSiteCreationSiteType>]
Copy link
Contributor

@samkabue samkabue Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep as a single line #Closed


## DESCRIPTION

This command obtains the current configuration information for the restricted site creation feature, including whether it is enabled, the current mode, and the current policies.
Copy link
Contributor

@samkabue samkabue Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

command

cmdlet #Closed

This command obtains the current configuration information for the restricted site creation feature, including whether it is enabled, the current mode, and the current policies.

> [!Important]
>You must use version 16.0.25513 (published November 2024) or later of the [SharePoint Online Management Shell](https://www.microsoft.com/en-us/download/details.aspx?id=3558) for these commands to function properly. Earlier versions do not have the current list of site types and will not operate correctly.
Copy link
Contributor

@samkabue samkabue Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this part -- it's not required, and we prefer not to keep such info since it becomes stale pretty soon.

admins already understand to install latest module if a cmdlet is missing from their install shell version #Closed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During private preview, we realized we needed to redefine the values of the RestrictedSiteCreationSiteType enum before GA. This change will ship with the November 2024 version of TAPS, but unfortunately means that older versions of TAPS use the wrong enum and will cause confusion for customers.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is you'll now have to come back and update this documentation at some time to remove this note.

And oh, we don't yet know what build number for November is -- until the PM picks it we shouldn't assume it'll be 25513


## RELATED LINKS

[Getting started with SharePoint Online Management Shell](https://learn.microsoft.com/powershell/sharepoint/sharepoint-online/connect-sharepoint-online)
Copy link
Contributor

@samkabue samkabue Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://learn.microsoft.com/powershell/sharepoint/sharepoint-online/connect-sharepoint-online

we prefer relative links, so

/powershell/sharepoint/sharepoint-online/connect-sharepoint-online
``` #Closed

@vgaddam-pm vgaddam-pm requested a review from samkabue November 15, 2024 23:56
Copy link
Contributor

Learn Build status updates of commit 6995e4b:

✅ Validation status: passed

File Status Preview URL Details
sharepoint/sharepoint-ps/sharepoint-online/Get-SPORestrictedSiteCreation ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 78ce8f9:

✅ Validation status: passed

File Status Preview URL Details
sharepoint/sharepoint-ps/sharepoint-online/Get-SPORestrictedSiteCreation.md ✅Succeeded View (sharepoint-ps)

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

@samkabue samkabue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@samkabue samkabue added Sign off The pull request is ready to be reviewed and merged by PubOps and removed Back to submitter The pull request didn't pass the review criteria and has been returned to the writer for updates Sign off The pull request is ready to be reviewed and merged by PubOps labels Nov 16, 2024
Copy link
Contributor

@samkabue samkabue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

This cmdlet obtains the current configuration information for the restricted site creation feature, including whether it is enabled, the current mode, and the current policies.

> [!Important]
>You must use version 16.0.25513 (published November 2024) or later of the [SharePoint Online Management Shell](https://www.microsoft.com/en-us/download/details.aspx?id=3558) for these commands to function properly. Earlier versions do not have the current list of site types and will not operate correctly.
Copy link
Contributor

@samkabue samkabue Nov 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

id=3558

I think this link is incorrect -- it doesnt resolve #Closed

@samkabue samkabue added the Back to submitter The pull request didn't pass the review criteria and has been returned to the writer for updates label Nov 16, 2024
Updated link for SharePoint Online Management Shell Download
@vgaddam-pm vgaddam-pm requested a review from samkabue November 16, 2024 02:32
Copy link
Contributor

Learn Build status updates of commit 6e1c7f9:

✅ Validation status: passed

File Status Preview URL Details
sharepoint/sharepoint-ps/sharepoint-online/Get-SPORestrictedSiteCreation.md ✅Succeeded View (sharepoint-ps)

For more details, please refer to the build report.

For any questions, please:

@vgaddam-pm vgaddam-pm marked this pull request as draft November 19, 2024 23:16
@vgaddam-pm vgaddam-pm marked this pull request as ready for review November 19, 2024 23:16
This cmdlet obtains the current configuration information for the restricted site creation feature, including whether it is enabled, the current mode, and the current policies.

> [!Important]
>You must use version 16.0.25513 (published November 2024) or later of the [SharePoint Online Management Shell](https://www.microsoft.com/en-us/download/details.aspx?id=35588&msockid=3bc54cadb1bd648039325ff4b0b5653a) for these commands to function properly. Earlier versions do not have the current list of site types and will not operate correctly.
Copy link
Contributor

@samkabue samkabue Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

16.0.25513

also as mentioned in the other PR: we don't yet know if this will be the actual November build. #Closed

This cmdlet obtains the current configuration information for the restricted site creation feature, including whether it is enabled, the current mode, and the current policies.

> [!Important]
>You must use version 16.0.25513 (published November 2024) or later of the [SharePoint Online Management Shell](https://www.microsoft.com/en-us/download/details.aspx?id=35588&msockid=3bc54cadb1bd648039325ff4b0b5653a) for these commands to function properly. Earlier versions do not have the current list of site types and will not operate correctly.
Copy link
Contributor

@samkabue samkabue Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

16.0.25513

use the full build number:

16.0.25513.12000
``` #Closed

@vgaddam-pm vgaddam-pm requested a review from samkabue December 4, 2024 23:02
Copy link
Contributor

Learn Build status updates of commit 00d1b83:

✅ Validation status: passed

File Status Preview URL Details
sharepoint/sharepoint-ps/sharepoint-online/Get-SPORestrictedSiteCreation.md ✅Succeeded View (sharepoint-ps)

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit dd2da74:

✅ Validation status: passed

File Status Preview URL Details
sharepoint/sharepoint-ps/sharepoint-online/Get-SPORestrictedSiteCreation.md ✅Succeeded View (sharepoint-ps)

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

@samkabue samkabue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@samkabue samkabue added Sign off The pull request is ready to be reviewed and merged by PubOps and removed Back to submitter The pull request didn't pass the review criteria and has been returned to the writer for updates labels Dec 5, 2024
@Stacyrch140 Stacyrch140 self-assigned this Dec 5, 2024
@Stacyrch140 Stacyrch140 added the In review PubOps is reviewing the pull request label Dec 5, 2024
@Stacyrch140
Copy link
Contributor

Hi @vgaddam-pm -

Following is a blocking issue that needs to be resolved before we can merge:

sharepoint/sharepoint-ps/sharepoint-online/Get-SPORestrictedSiteCreation.md

  • Update a relevant TOC with this file addition, and include the TOC with this PR.

Reference

Criteria used for pull request reviews

Blocking

  • When a new article is added, the same PR must also contain at least one updated TOC with an entry for the new article. Exceptions are allowed when the file has ROBOTS: NOINDEX, NOFOLLOW in the metadata.

After you resolve the blocking issues, remove the Back to submitter label and add the Sign off label again.

If you need help resolving issues in this PR, post your question in the Ask an Admin Teams Channel.

Thanks,
Stacy

@Stacyrch140 Stacyrch140 added Back to submitter The pull request didn't pass the review criteria and has been returned to the writer for updates and removed In review PubOps is reviewing the pull request Sign off The pull request is ready to be reviewed and merged by PubOps labels Dec 5, 2024
@vgaddam-pm vgaddam-pm marked this pull request as draft December 5, 2024 19:09
@vgaddam-pm vgaddam-pm marked this pull request as ready for review December 5, 2024 19:11
Copy link
Contributor

Learn Build status updates of commit 5e8a643:

✅ Validation status: passed

File Status Preview URL Details
sharepoint/sharepoint-ps/sharepoint-online/Get-SPORestrictedSiteCreation.md ✅Succeeded View (sharepoint-ps)
sharepoint/sharepoint-ps/sharepoint-online/sharepoint-online.md ✅Succeeded View (sharepoint-ps)

For more details, please refer to the build report.

For any questions, please:

@vgaddam-pm vgaddam-pm requested a review from samkabue December 5, 2024 19:18
@vgaddam-pm
Copy link
Contributor Author

@Stacyrch140 to review now. Have added to TOC but cannot assign labels myself.

@samkabue samkabue added Sign off The pull request is ready to be reviewed and merged by PubOps and removed Back to submitter The pull request didn't pass the review criteria and has been returned to the writer for updates labels Dec 9, 2024
@rjagiewich rjagiewich added the In review PubOps is reviewing the pull request label Dec 9, 2024
Copy link
Contributor

Learn Build status updates of commit e798259:

✅ Validation status: passed

File Status Preview URL Details
sharepoint/sharepoint-ps/sharepoint-online/Get-SPORestrictedSiteCreation.md ✅Succeeded View (sharepoint-ps)
sharepoint/sharepoint-ps/sharepoint-online/sharepoint-online.md ✅Succeeded View (sharepoint-ps)

For more details, please refer to the build report.

For any questions, please:

@rjagiewich rjagiewich self-assigned this Dec 9, 2024
@rjagiewich rjagiewich merged commit 7c83bc0 into MicrosoftDocs:main Dec 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In review PubOps is reviewing the pull request Microsoft submitter Sign off The pull request is ready to be reviewed and merged by PubOps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants