Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inaccurate placeholder text event-hub-assign-roles.md #123586

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

liam-stevenson
Copy link

Slight wording change to the example PowerShell command to add a role assignement as "yourStorageAccountId" may be confusing to new users or less experienced users.

The placeholder suggests that you needed a Storage Account ID when it should be clearer that you need the ResourceId from the previous Get-AzResource command.

Slight wording change to the example PowerShell command to add a role assignement. The placeholder was misleading that you needed a Storage Account ID when it should be clearer that you need the ResourceId from the previous Get-AzResource command.
Copy link
Contributor

@liam-stevenson : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 23c532c:

✅ Validation status: passed

File Status Preview URL Details
includes/passwordless/event-hub/event-hub-assign-roles.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented Jul 1, 2024

@alexwolfmsft

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants