Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Power BI Azure Maps visual: Add dynamic reference layer instruction #123597

Merged

Conversation

alankashiwa
Copy link
Contributor

Adds the instruction of dynamic reference layer configuration. This feature will be public in mid-July.

Copy link
Contributor

@alankashiwa : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@deniseatmicrosoft
Copy link
Contributor

#assign-reviewer: stevemunk

Copy link
Contributor

Learn Build status updates of commit 54fab45:

💡 Validation status: suggestions

File Status Preview URL Details
articles/azure-maps/power-bi-visual-add-reference-layer.md 💡Suggestion Details
articles/azure-maps/media/power-bi-visual/reference-layer-hosted-dax.png ✅Succeeded
articles/azure-maps/media/power-bi-visual/reference-layer-hosted.png ✅Succeeded

articles/azure-maps/power-bi-visual-add-reference-layer.md

  • Line 50, Column 81: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/dax/' will be broken in isolated environments. Replace with a relative link.
  • Line 50, Column 160: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/dax/' will be broken in isolated environments. Replace with a relative link.
  • Line 121, Column 47: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/power-bi/create-reports/desktop-conditional-format-visual-titles' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Image File This PR added or updated an image file(s).

@Court72
Copy link
Contributor

Court72 commented Jul 2, 2024

@deniseatmicrosoft

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Jul 2, 2024
alankashiwa and others added 2 commits July 3, 2024 10:41
Fix grammar issue

Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com>
Phrase wording based on feedback

Co-authored-by: steve munk <33468793+stevemunk@users.noreply.github.com>
Copy link
Contributor

Learn Build status updates of commit 7a4bdba:

💡 Validation status: suggestions

File Status Preview URL Details
articles/azure-maps/power-bi-visual-add-reference-layer.md 💡Suggestion Details
articles/azure-maps/media/power-bi-visual/reference-layer-hosted-dax.png ✅Succeeded
articles/azure-maps/media/power-bi-visual/reference-layer-hosted.png ✅Succeeded

articles/azure-maps/power-bi-visual-add-reference-layer.md

  • Line 50, Column 81: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/dax/' will be broken in isolated environments. Replace with a relative link.
  • Line 121, Column 47: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/power-bi/create-reports/desktop-conditional-format-visual-titles' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Image File This PR added or updated an image file(s).

Copy link
Contributor

Learn Build status updates of commit 1884bd9:

💡 Validation status: suggestions

File Status Preview URL Details
articles/azure-maps/power-bi-visual-add-reference-layer.md 💡Suggestion Details
articles/azure-maps/media/power-bi-visual/reference-layer-hosted-dax.png ✅Succeeded
articles/azure-maps/media/power-bi-visual/reference-layer-hosted.png ✅Succeeded

articles/azure-maps/power-bi-visual-add-reference-layer.md

  • Line 50, Column 81: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/dax/' will be broken in isolated environments. Replace with a relative link.
  • Line 121, Column 47: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/power-bi/create-reports/desktop-conditional-format-visual-titles' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Image File This PR added or updated an image file(s).

@Jak-MS
Copy link
Contributor

Jak-MS commented Jul 3, 2024

@deniseatmicrosoft - since you assigned @stevemunk to review and he's approved, can you add your sign off ?

Note: I addressed the Validation issues concerning absolute links.

Copy link
Contributor

Learn Build status updates of commit 5b133be:

✅ Validation status: passed

File Status Preview URL Details
articles/azure-maps/media/power-bi-visual/reference-layer-hosted-dax.png ✅Succeeded
articles/azure-maps/media/power-bi-visual/reference-layer-hosted.png ✅Succeeded
articles/azure-maps/power-bi-visual-add-reference-layer.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Image File This PR added or updated an image file(s).

@deniseatmicrosoft
Copy link
Contributor

#sign-off

@Court72
Copy link
Contributor

Court72 commented Jul 4, 2024

I staged the new images in https://github.com/MicrosoftDocs/azure-docs-pr/pull/280090. They rendered as expected. Merging now.

@Court72 Court72 merged commit 17be420 into MicrosoftDocs:main Jul 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants