Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the Edge old versions detector and remove a couple of outdated versions #3144

Merged
merged 1 commit into from
May 3, 2024
Merged

Improve the Edge old versions detector and remove a couple of outdated versions #3144

merged 1 commit into from
May 3, 2024

Conversation

captainbrosset
Copy link
Contributor

@captainbrosset captainbrosset commented May 3, 2024 •
edited by github-actions bot
Loading

Fixes #3142.

The WebView2 release note files have changed, so I needed to change the script that detects old versions of Edge a little bit.
In this PR, I'm also removing a couple of Edge 123 occurrences, since these have now been in Stable for a while.

AB#50579994

@captainbrosset captainbrosset added the cat: general General content. label May 3, 2024
mikehoffms
mikehoffms approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved PR per Writer/Editor review.

@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit be4090a:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/devtools-guide-chromium/memory-problems/heap-snapshots.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/memory-problems/memory-101.md ✅Succeeded View
scripts/report-references-to-old-versions.js ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@captainbrosset captainbrosset merged commit b17756e into main May 3, 2024
3 checks passed
@captainbrosset captainbrosset deleted the user/pabrosse/old-edge-versions branch May 3, 2024 13:31
@captainbrosset captainbrosset mentioned this pull request May 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikehoffms mikehoffms mikehoffms approved these changes

Assignees
No one assigned
Labels
cat: general General content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Outdated Edge version references found
2 participants
@captainbrosset @mikehoffms