Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Privacy: Expand Compose, revise Copilot #3206

Merged
merged 15 commits into from
Jul 9, 2024
Merged

Privacy: Expand Compose, revise Copilot #3206

merged 15 commits into from
Jul 9, 2024

Conversation

majenny
Copy link
Contributor

@majenny majenny commented Jun 24, 2024 •
edited by mikehoffms
Loading

@majenny majenny requested a review from mikehoffms June 24, 2024 17:17
sanketj
sanketj suggested changes Jun 24, 2024
View reviewed changes
microsoft-edge/privacy-whitepaper/index.md Outdated Show resolved Hide resolved
microsoft-edge/privacy-whitepaper/index.md Outdated Show resolved Hide resolved
microsoft-edge/privacy-whitepaper/index.md Show resolved Hide resolved
apryzgoda
apryzgoda requested changes Jun 28, 2024
View reviewed changes
microsoft-edge/privacy-whitepaper/index.md Outdated Show resolved Hide resolved
microsoft-edge/privacy-whitepaper/index.md Outdated Show resolved Hide resolved
microsoft-edge/privacy-whitepaper/index.md Outdated Show resolved Hide resolved
microsoft-edge/privacy-whitepaper/index.md Outdated Show resolved Hide resolved
microsoft-edge/privacy-whitepaper/index.md Outdated Show resolved Hide resolved
microsoft-edge/privacy-whitepaper/index.md Outdated Show resolved Hide resolved
microsoft-edge/privacy-whitepaper/index.md Outdated Show resolved Hide resolved
microsoft-edge/privacy-whitepaper/index.md Outdated Show resolved Hide resolved
microsoft-edge/privacy-whitepaper/index.md Outdated Show resolved Hide resolved
microsoft-edge/privacy-whitepaper/index.md Outdated Show resolved Hide resolved
@mikehoffms mikehoffms changed the title Adding privacy entry for Compose inline rewrite Privacy: Expand Compose, revise Copilot Jul 1, 2024
mikehoffms
mikehoffms approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved PR per Writer/Editor review, after revisions were made.

@majenny
Copy link
Contributor Author

majenny commented Jul 1, 2024 •
edited
Loading

This PR LGTM, thanks all for reviewing!

sanketj
sanketj approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@sanketj sanketj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one suggestion.

microsoft-edge/privacy-whitepaper/index.md Outdated Show resolved Hide resolved
apryzgoda
apryzgoda requested changes Jul 1, 2024
View reviewed changes
microsoft-edge/privacy-whitepaper/index.md Outdated Show resolved Hide resolved
microsoft-edge/privacy-whitepaper/index.md Outdated Show resolved Hide resolved
microsoft-edge/privacy-whitepaper/index.md Outdated Show resolved Hide resolved
microsoft-edge/privacy-whitepaper/index.md Outdated Show resolved Hide resolved
microsoft-edge/privacy-whitepaper/index.md Outdated Show resolved Hide resolved
microsoft-edge/privacy-whitepaper/index.md Outdated Show resolved Hide resolved
microsoft-edge/privacy-whitepaper/index.md Outdated Show resolved Hide resolved
microsoft-edge/privacy-whitepaper/index.md Outdated Show resolved Hide resolved
@majenny @apryzgoda
Update microsoft-edge/privacy-whitepaper/index.md
e5c9e34 
Co-authored-by: apryzgoda <133698995+apryzgoda@users.noreply.github.com>
@mikehoffms mikehoffms requested a review from apryzgoda July 2, 2024 19:14
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit 25f8f70:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/privacy-whitepaper/index-images/compose.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/privacy-whitepaper/index-images/settings-and-more-icon.png ✅Succeeded View
microsoft-edge/privacy-whitepaper/index-images/summarize-content.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/privacy-whitepaper/index.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

apryzgoda
apryzgoda approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@apryzgoda apryzgoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edge Privacy Champ approved

@captainbrosset captainbrosset merged commit abd9eb3 into main Jul 9, 2024
2 checks passed
@captainbrosset captainbrosset deleted the user/majenny/ComposeInlinePrivacy branch July 9, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikehoffms mikehoffms mikehoffms approved these changes

@sanketj sanketj sanketj approved these changes

@apryzgoda apryzgoda apryzgoda approved these changes

Assignees
No one assigned
Labels
cat: privacy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@majenny @sanketj @mikehoffms @apryzgoda @captainbrosset