-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Notes for July 2024 #3218
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* [ICoreWebView2FileSystemHandle::get_Permission](/microsoft-edge/webview2/reference/win32/icorewebview2filesystemhandle?view=webview2-1.0.2651.64&preserve-view=true#get_permission) | ||
|
||
* [ICoreWebView2ObjectCollection](/microsoft-edge/webview2/reference/win32/icorewebview2objectcollection?view=webview2-1.0.2651.64&preserve-view=true) | ||
* [ICoreWebView2ObjectCollection::get_Kind](/microsoft-edge/webview2/reference/win32/icorewebview2objectcollection?view=webview2-1.0.2651.64&preserve-view=true#get_kind)<!-- todo: test, b/c anchor section seems to not exist, in earlier release. finding: get or get_Kind is missing from API Ref open PR: https://review.learn.microsoft.com/en-us/microsoft-edge/webview2/reference/win32/icorewebview2objectcollection?view=webview2-win32-preview&branch=pr-en-us-94 - Also, get or get_Kind is missing from released Ref docs: https://learn.microsoft.com/en-us/microsoft-edge/webview2/reference/win32/icorewebview2objectcollection?view=webview2-1.0.2646-prerelease --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ICoreWebView2ObjectCollection::get_Kind is missing from the open API Ref PR in the ObjectCollection type topic (so this link is "404", ie, defaults to top of webpage b/c there's no anchor section) (2651 Release):
https://review.learn.microsoft.com/en-us/microsoft-edge/webview2/reference/win32/icorewebview2objectcollection?view=webview2-win32-preview&branch=pr-en-us-94
A "get" method is also missing from previous Ref docs. The topic says that this ObjectCollection is "Used to get, remove and add objects at the specified index", but no 'get' method is listed in API Ref (live Ref docs or latest draft PR). Yet in older RelNotes list & latest draft RelNotes list, there's a get_Kind method (assume emitted by the script), pointing to such an anchor section.
Also, based on the type's description, I'd expect get_Item, not get_Kind.
Live Ref docs (2646-pre) for the type, missing a get method:
https://learn.microsoft.com/en-us/microsoft-edge/webview2/reference/win32/icorewebview2objectcollection?view=webview2-1.0.2646-prerelease
@@ -330,9 +661,9 @@ The following APIs have been promoted from Experimental to Stable in this Prerel | |||
* [ICoreWebView2FileSystemHandle::get_Permission](/microsoft-edge/webview2/reference/win32/icorewebview2filesystemhandle?view=webview2-1.0.2646-prerelease&preserve-view=true#get_permission) | |||
|
|||
* [ICoreWebView2ObjectCollection](/microsoft-edge/webview2/reference/win32/icorewebview2objectcollection?view=webview2-1.0.2646-prerelease&preserve-view=true) | |||
* [ICoreWebView2ObjectCollection::RemoveValueAtIndex](/microsoft-edge/webview2/reference/win32/icorewebview2objectcollection?view=webview2-1.0.2646-prerelease&preserve-view=true#removevalueatindex) | |||
* [ICoreWebView2ObjectCollection::get_Kind](/microsoft-edge/webview2/reference/win32/icorewebview2objectcollection?view=webview2-1.0.2646-prerelease&preserve-view=true#get_kind)<!-- todo: test, b/c anchor section seems to not exist --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as the Comment in newer section. This link is like a 404; it defaults to top of the API Ref webpage for objcollection type, b/c no such "get" anchor section exists in Ref docs.
this instance of the get_Kind link is in section:
1.0.2646-prerelease -- June 19, 2024 -- The following APIs have been promoted from Experimental to Stable in this Prerelease SDK.
@peiche-jessica @victorhuangwq
Learn Build status updates of commit 53f640f: 💡 Validation status: suggestions
microsoft-edge/webview2/release-notes/index.md
This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
|
||
|
||
<!-- ---------- --> | ||
* Updated the WebMessageObjects API to allow injecting DOM objects into WebView2 content that's constructed via the app, and via the `CoreWebView2.PostWebMessage` API in the other direction. Added a new web object type to represent a file system handle that can be posted to the web content to provide it with filesystem access. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Updated the WebMessageObjects API to allow injecting DOM objects into WebView2 content that's constructed via the app, and via the `CoreWebView2.PostWebMessage` API in the other direction. Added a new web object type to represent a file system handle that can be posted to the web content to provide it with filesystem access. | |
* Updated the WebMessageObjects API (such as `typeName.memberName` and `typeName.memberName`) to allow injecting DOM objects into WebView2 content that's constructed via the app, and via the `CoreWebView2.PostWebMessage` API in the other direction. Added a new web object type (`typeName`) to represent a file system handle that can be posted to the web content to provide it with filesystem access. |
In order to place this list of APIs within "Overview of APIs" such as within section:
Overview of WebView2 features and APIs > Web/native interop > Web messaging
need to specify which APIs are being referred to, in the lead-in text. Which typeName and memberName is the lead-in text referring to?
Expect this tab-set and lead-in to be somehow integrated into live article section:
https://learn.microsoft.com/microsoft-edge/webview2/concepts/overview-features-apis#web-messaging
@victorhuangwq @peiche-jessica
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rendered article for review:
https://review.learn.microsoft.com/microsoft-edge/webview2/release-notes/index?branch=pr-en-us-3218
AB#52408443