Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Notes for July 2024 #3218

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

mikehoffms
Copy link
Contributor

@mikehoffms mikehoffms commented Jul 9, 2024

@mikehoffms mikehoffms added the cat: webview2 WebView-related content. label Jul 9, 2024
@mikehoffms mikehoffms marked this pull request as ready for review July 25, 2024 17:29
Copy link
Contributor

@victorhuangwq victorhuangwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* [ICoreWebView2FileSystemHandle::get_Permission](/microsoft-edge/webview2/reference/win32/icorewebview2filesystemhandle?view=webview2-1.0.2651.64&preserve-view=true#get_permission)

* [ICoreWebView2ObjectCollection](/microsoft-edge/webview2/reference/win32/icorewebview2objectcollection?view=webview2-1.0.2651.64&preserve-view=true)
* [ICoreWebView2ObjectCollection::get_Kind](/microsoft-edge/webview2/reference/win32/icorewebview2objectcollection?view=webview2-1.0.2651.64&preserve-view=true#get_kind)<!-- todo: test, b/c anchor section seems to not exist, in earlier release. finding: get or get_Kind is missing from API Ref open PR: https://review.learn.microsoft.com/en-us/microsoft-edge/webview2/reference/win32/icorewebview2objectcollection?view=webview2-win32-preview&branch=pr-en-us-94 - Also, get or get_Kind is missing from released Ref docs: https://learn.microsoft.com/en-us/microsoft-edge/webview2/reference/win32/icorewebview2objectcollection?view=webview2-1.0.2646-prerelease -->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ICoreWebView2ObjectCollection::get_Kind is missing from the open API Ref PR in the ObjectCollection type topic (so this link is "404", ie, defaults to top of webpage b/c there's no anchor section) (2651 Release):
https://review.learn.microsoft.com/en-us/microsoft-edge/webview2/reference/win32/icorewebview2objectcollection?view=webview2-win32-preview&branch=pr-en-us-94

A "get" method is also missing from previous Ref docs. The topic says that this ObjectCollection is "Used to get, remove and add objects at the specified index", but no 'get' method is listed in API Ref (live Ref docs or latest draft PR). Yet in older RelNotes list & latest draft RelNotes list, there's a get_Kind method (assume emitted by the script), pointing to such an anchor section.

Also, based on the type's description, I'd expect get_Item, not get_Kind.

Live Ref docs (2646-pre) for the type, missing a get method:
https://learn.microsoft.com/en-us/microsoft-edge/webview2/reference/win32/icorewebview2objectcollection?view=webview2-1.0.2646-prerelease

@peiche-jessica @victorhuangwq

@@ -330,9 +661,9 @@ The following APIs have been promoted from Experimental to Stable in this Prerel
* [ICoreWebView2FileSystemHandle::get_Permission](/microsoft-edge/webview2/reference/win32/icorewebview2filesystemhandle?view=webview2-1.0.2646-prerelease&preserve-view=true#get_permission)

* [ICoreWebView2ObjectCollection](/microsoft-edge/webview2/reference/win32/icorewebview2objectcollection?view=webview2-1.0.2646-prerelease&preserve-view=true)
* [ICoreWebView2ObjectCollection::RemoveValueAtIndex](/microsoft-edge/webview2/reference/win32/icorewebview2objectcollection?view=webview2-1.0.2646-prerelease&preserve-view=true#removevalueatindex)
* [ICoreWebView2ObjectCollection::get_Kind](/microsoft-edge/webview2/reference/win32/icorewebview2objectcollection?view=webview2-1.0.2646-prerelease&preserve-view=true#get_kind)<!-- todo: test, b/c anchor section seems to not exist -->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as the Comment in newer section. This link is like a 404; it defaults to top of the API Ref webpage for objcollection type, b/c no such "get" anchor section exists in Ref docs.

this instance of the get_Kind link is in section:
1.0.2646-prerelease -- June 19, 2024 -- The following APIs have been promoted from Experimental to Stable in this Prerelease SDK.
@peiche-jessica @victorhuangwq

@MicrosoftDocs MicrosoftDocs deleted a comment from piotrula85 Aug 5, 2024
Copy link

Learn Build status updates of commit 53f640f:

💡 Validation status: suggestions

File Status Preview URL Details
microsoft-edge/webview2/release-notes/index.md 💡Suggestion View Details
microsoft-edge/webview2/release-notes/archive.md ✅Succeeded View

microsoft-edge/webview2/release-notes/index.md

  • Line 207, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/microsoft.web.webview2.core.corewebview2frame.useoverridetimerwakeinterval?view=webview2-dotnet-1.0.2730-prerelease&preserve-view=true' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 210, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/microsoft.web.webview2.core.corewebview2settings.preferredbackgroundtimerwakeinterval?view=webview2-dotnet-1.0.2730-prerelease&preserve-view=true' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 211, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/microsoft.web.webview2.core.corewebview2settings.preferredforegroundtimerwakeinterval?view=webview2-dotnet-1.0.2730-prerelease&preserve-view=true' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 212, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/microsoft.web.webview2.core.corewebview2settings.preferredintensivetimerwakeinterval?view=webview2-dotnet-1.0.2730-prerelease&preserve-view=true' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 213, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/microsoft.web.webview2.core.corewebview2settings.preferredoverridetimerwakeinterval?view=webview2-dotnet-1.0.2730-prerelease&preserve-view=true' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 228, Column 3: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2experimentalframe7?view=webview2-1.0.2730-prerelease&preserve-view=true' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 229, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2experimentalframe7?view=webview2-1.0.2730-prerelease&preserve-view=true#get_useoverridetimerwakeinterval' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 230, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2experimentalframe7?view=webview2-1.0.2730-prerelease&preserve-view=true#put_useoverridetimerwakeinterval' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 232, Column 3: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2experimentalsettings9?view=webview2-1.0.2730-prerelease&preserve-view=true' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 233, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2experimentalsettings9?view=webview2-1.0.2730-prerelease&preserve-view=true#get_preferredbackgroundtimerwakeintervalinmilliseconds' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 234, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2experimentalsettings9?view=webview2-1.0.2730-prerelease&preserve-view=true#get_preferredforegroundtimerwakeintervalinmilliseconds' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 235, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2experimentalsettings9?view=webview2-1.0.2730-prerelease&preserve-view=true#get_preferredintensivetimerwakeintervalinmilliseconds' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 236, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2experimentalsettings9?view=webview2-1.0.2730-prerelease&preserve-view=true#get_preferredoverridetimerwakeintervalinmilliseconds' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 237, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2experimentalsettings9?view=webview2-1.0.2730-prerelease&preserve-view=true#put_preferredbackgroundtimerwakeintervalinmilliseconds' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 238, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2experimentalsettings9?view=webview2-1.0.2730-prerelease&preserve-view=true#put_preferredforegroundtimerwakeintervalinmilliseconds' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 239, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2experimentalsettings9?view=webview2-1.0.2730-prerelease&preserve-view=true#put_preferredintensivetimerwakeintervalinmilliseconds' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 240, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2experimentalsettings9?view=webview2-1.0.2730-prerelease&preserve-view=true#put_preferredoverridetimerwakeintervalinmilliseconds' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 312, Column 3: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2_25?view=webview2-1.0.2730-prerelease&preserve-view=true' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 313, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2_25?view=webview2-1.0.2730-prerelease&preserve-view=true#add_saveasuishowing' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 314, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2_25?view=webview2-1.0.2730-prerelease&preserve-view=true#remove_saveasuishowing' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 315, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2_25?view=webview2-1.0.2730-prerelease&preserve-view=true#showsaveasui' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 317, Column 3: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2showsaveasuicompletedhandler?view=webview2-1.0.2730-prerelease&preserve-view=true' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 319, Column 3: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2saveasuishowingeventargs?view=webview2-1.0.2730-prerelease&preserve-view=true' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 320, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2saveasuishowingeventargs?view=webview2-1.0.2730-prerelease&preserve-view=true#get_allowreplace' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 321, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2saveasuishowingeventargs?view=webview2-1.0.2730-prerelease&preserve-view=true#get_cancel' points to a learn site page that doesn't exist. Check the path or URL and update the link.

This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request.
For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:



<!-- ---------- -->
* Updated the WebMessageObjects API to allow injecting DOM objects into WebView2 content that's constructed via the app, and via the `CoreWebView2.PostWebMessage` API in the other direction. Added a new web object type to represent a file system handle that can be posted to the web content to provide it with filesystem access.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Updated the WebMessageObjects API to allow injecting DOM objects into WebView2 content that's constructed via the app, and via the `CoreWebView2.PostWebMessage` API in the other direction. Added a new web object type to represent a file system handle that can be posted to the web content to provide it with filesystem access.
* Updated the WebMessageObjects API (such as `typeName.memberName` and `typeName.memberName`) to allow injecting DOM objects into WebView2 content that's constructed via the app, and via the `CoreWebView2.PostWebMessage` API in the other direction. Added a new web object type (`typeName`) to represent a file system handle that can be posted to the web content to provide it with filesystem access.

In order to place this list of APIs within "Overview of APIs" such as within section:
Overview of WebView2 features and APIs > Web/native interop > Web messaging
need to specify which APIs are being referred to, in the lead-in text. Which typeName and memberName is the lead-in text referring to?
Expect this tab-set and lead-in to be somehow integrated into live article section:
https://learn.microsoft.com/microsoft-edge/webview2/concepts/overview-features-apis#web-messaging
@victorhuangwq @peiche-jessica

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my attempted mapping from lead-in text to API list:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: webview2 WebView-related content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants