Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in JS AddHostObjectAsyncProxyBase & AddHostObjectSyncProxy #3243

Merged
merged 4 commits into from
Aug 7, 2024

Conversation

srwei
Copy link
Contributor

@srwei srwei commented Aug 5, 2024

@mikehoffms mikehoffms changed the title Fix some typos in WebView2 Javascript AddHostObjectAsyncProxyBase and AddHostObjectSyncProxy Fix typos in JS AddHostObjectAsyncProxyBase & AddHostObjectSyncProxy Aug 5, 2024
Copy link

Learn Build status updates of commit a3d8873:

💡 Validation status: suggestions

File Status Preview URL Details
microsoft-edge/webview2/reference/javascript/hostobjectasyncproxybase.yml 💡Suggestion View Details
microsoft-edge/webview2/reference/javascript/hostobjectsyncproxy.yml 💡Suggestion View Details

microsoft-edge/webview2/reference/javascript/hostobjectasyncproxybase.yml

  • Line 137, Column 19: [Suggestion: other-site-link-broken - See documentation] Link 'https://microsoft.github.io/PowerBI-JavaScript/interfaces/_node_modules_typedoc_node_modules_typescript_lib_lib_es5_d_.callablefunction.html' points to a page that doesn't exist. Check the path or URL and update the link.

microsoft-edge/webview2/reference/javascript/hostobjectsyncproxy.yml

  • Line 146, Column 19: [Suggestion: other-site-link-broken - See documentation] Link 'https://microsoft.github.io/PowerBI-JavaScript/interfaces/_node_modules_typedoc_node_modules_typescript_lib_lib_es5_d_.callablefunction.html' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix links per build status report / 2 PR Comments. per Writer/Editor review.

Copy link

Learn Build status updates of commit 9457dfa:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/webview2/reference/javascript/hostobjectasyncproxybase.yml ✅Succeeded View
microsoft-edge/webview2/reference/javascript/hostobjectsyncproxy.yml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@mikehoffms mikehoffms added the cat: webview2 WebView-related content. label Aug 6, 2024
Copy link

Learn Build status updates of commit 47451a9:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/webview2/reference/javascript/hostobjectasyncproxybase.yml ✅Succeeded View
microsoft-edge/webview2/reference/javascript/hostobjectsyncproxy.yml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@mikehoffms mikehoffms self-requested a review August 6, 2024 20:58
Copy link
Contributor

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved PR per Writer/Editor review

Copy link

Learn Build status updates of commit 64d6838:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/webview2/reference/javascript/hostobjectasyncproxybase.yml ✅Succeeded View
microsoft-edge/webview2/reference/javascript/hostobjectsyncproxy.yml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@Reezaali Reezaali merged commit eb713ef into MicrosoftDocs:main Aug 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: webview2 WebView-related content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants