Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sample script #974

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

occasionallydennis
Copy link

This fixes the occasional "Get-MgBetaApplication : Cannot bind argument to parameter 'ApplicationId' because it is an empty string." on some apps.

This fixes the occasional "Get-MgBetaApplication : Cannot bind argument to parameter 'ApplicationId' because it is an empty string." on some apps.
Copy link
Contributor

@occasionallydennis : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit cfd32b6:

✅ Validation status: passed

File Status Preview URL Details
docs/identity/app-proxy/scripts/powershell-get-custom-domain-identical-cert.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented Jul 4, 2024

@kenwith

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Copy link
Contributor

@githubarpyka githubarpyka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should change line 80 like this:

$aadapAppId = Get-MgBetaApplication -Top 10000 | where-object {$_.AppId -eq $item.AppId}

@kenwith
Copy link
Member

kenwith commented Aug 1, 2024

@occasionallydennis - would you please make the changes mentioned above by Arpad and we can get this merged. Thank you for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants