-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added google looker documentation #501
base: main
Are you sure you want to change the base?
Conversation
Learn Build status updates of commit 23a5152:
|
File | Status | Preview URL | Details |
---|---|---|---|
powerquery-docs/connectors/google-looker.md | Details | ||
powerquery-docs/connectors/index.md | ✅Succeeded | ||
powerquery-docs/connectors/media/google-looker/host-connection-desktop.png | ✅Succeeded | ||
powerquery-docs/connectors/media/google-looker/host-connection-filled-desktop.png | ✅Succeeded | ||
powerquery-docs/connectors/media/index/looker-64.png | ✅Succeeded |
powerquery-docs/connectors/google-looker.md
- Line 2, Column 1: [Warning: author-missing - See documentation]
Missing required attribute: 'author'. Add the current author's GitHub ID.
- Line 2, Column 1: [Warning: ms-author-missing - See documentation]
Missing required attribute: 'ms.author'. Add the current author's Microsoft alias.
- Line 12, Column 1: [Warning: file-not-found - See documentation]
Invalid file link: './media/google-bigquery/Looker64.png'.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
Learn Build status updates of commit beb2c68:
|
File | Status | Preview URL | Details |
---|---|---|---|
powerquery-docs/connectors/google-looker.md | Details | ||
powerquery-docs/connectors/index.md | ✅Succeeded | ||
powerquery-docs/connectors/media/google-looker/host-connection-desktop.png | ✅Succeeded | ||
powerquery-docs/connectors/media/google-looker/host-connection-filled-desktop.png | ✅Succeeded | ||
powerquery-docs/connectors/media/index/looker-64.png | ✅Succeeded | ||
powerquery-docs/toc.yml | ✅Succeeded |
powerquery-docs/connectors/google-looker.md
- Line 2, Column 1: [Warning: author-missing - See documentation]
Missing required attribute: 'author'. Add the current author's GitHub ID.
- Line 2, Column 1: [Warning: ms-author-missing - See documentation]
Missing required attribute: 'ms.author'. Add the current author's Microsoft alias.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
Thank you for your contribution. Would you take a moment to sign the Contributor License Agreement (CLA)? After the CLA is signed, someone can review your pull request. Thanks! |
#label:"aq-pr-triaged" |
Hi all, sorry for the delay, we are still trying to figure out which company should sign the CLA. |
@microsoft-github-policy-service agree [company="Google"] |
@microsoft-github-policy-service agree company=Google |
@kenrickyap : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Hi @DougKlopfenstein, just wondering if you could provide an ETA for a review? Thanks! |
#assign:ptyx507x |
Users ptyx507x are already assigned. |
will be acting as the new POC of this PR |
Learn Build status updates of commit 7475be0: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue.
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
@kenrickyap could you please confirm that this PR contains the correct files / documentation for your connector? |
@DougKlopfenstein the index.md for connectors got conflicts due to the swich from :::image back to the old format. Do you want to fix that conflict here to prevent future issues? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I suggested three small edits.
Co-authored-by: lisameldridge <52974851+lisameldridge@users.noreply.github.com>
Co-authored-by: lisameldridge <52974851+lisameldridge@users.noreply.github.com>
Learn Build status updates of commit f52a42b: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
PRMerger Results
|
Learn Build status updates of commit a80e21e: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
PRMerger Results
|
Learn Build status updates of commit 0115a10: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
PRMerger Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small changes; otherwise, approved.
Learn Build status updates of commit c53ccd7: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
PRMerger Results
|
Co-authored-by: lisameldridge <52974851+lisameldridge@users.noreply.github.com>
Co-authored-by: lisameldridge <52974851+lisameldridge@users.noreply.github.com>
Learn Build status updates of commit 793a78f: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
PRMerger Results
|
Learn Build status updates of commit ba663f4: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
PRMerger Results
|
Learn Build status updates of commit 5e6e1c0: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
PRMerger Results
|
#hold |
Learn Build status updates of commit 4cfda27: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
PRMerger Results
|
Learn Build status updates of commit b3db00b: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
PRMerger Results
|
Google looker connector is currently in the process of being certified, as part of the certification process we needed to provided documentation.