Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR Updated BaseUrl, Removed Beta Flag, and Added New Tables and Features #572

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

cquintero89
Copy link

Updated Version: [Version = "1.2.1"]
Key Changes:

  1. Updated the BaseUrl field to reflect the new base URL.
  2. Removed the Beta flag, making the connector production-ready.
  3. Added the following new tables:
    o Delegations (GenericTableNavigator("generic", "delegations"))
    o Delegation Items (GenericTableNavigator("generic", "delegation-items"))
    o Delegated Tasks (GenericTableNavigator("generic", "delegated-tasks"))
    o Instance Approvers (GenericInstanceApproversFunction.Contents)
  4. Added optional date range parameters (start and end) for some additional functions and tables to enhance flexibility in querying data.

@prmerger-automator prmerger-automator bot added the do-not-merge Don't merge this yet label Nov 25, 2024
Copy link
Contributor

@cquintero89 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 3a505b4:

⚠️ Validation status: warnings

File Status Preview URL Details
powerquery-docs/connectors/automy-data-analytics.md ⚠️Warning Details

powerquery-docs/connectors/automy-data-analytics.md

  • Line 4, Column 9: [Warning: author-not-found - See documentation] Invalid value for author: 'Carlos Quintero' is not a valid GitHub ID.
  • Line 7, Column 12: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'cquintero89' is not a valid Microsoft alias.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@Jak-MS
Copy link
Contributor

Jak-MS commented Nov 25, 2024

@DougKlopfenstein
Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@DougKlopfenstein
Copy link
Collaborator

Hi @cquintero89 - in addition to the changes you need to make above, you'll also need to remove the "(Beta)" tag from your connector name in the table of contents (toc.yml) and the list of all connectors (index.md).

Copy link
Contributor

Learn Build status updates of commit 268d6f4:

✅ Validation status: passed

File Status Preview URL Details
powerquery-docs/connectors/automy-data-analytics.md ✅Succeeded
powerquery-docs/toc.yml ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.

@cquintero89
Copy link
Author

Hi @DougKlopfenstein, I have addressed the requested changes. Please let me know if there’s anything else to modify. Thank you!

@DougKlopfenstein
Copy link
Collaborator

Hi @cquintero89 - You also need to remove the "(Beta)" tag and redo the "by ACEROYALTY" name for your connector in the list of all connectors (connectors/index.md).
image

Copy link
Contributor

Learn Build status updates of commit 4983daa:

✅ Validation status: passed

File Status Preview URL Details
powerquery-docs/connectors/automy-data-analytics.md ✅Succeeded
powerquery-docs/connectors/index.md ✅Succeeded
powerquery-docs/toc.yml ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
Index File This PR contains a change to the index file.

@cquintero89
Copy link
Author

Hi @DougKlopfenstein, I have addressed the changes by removing the "(Beta)" tag and updating the "by ACEROYALTY" to "by AUTOMY". Please let me know if further adjustments are needed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants