Update sp-executesql-transact-sql.md #9823
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are way more than 12 statements generated. You get one statement for each year and month combination for each language where the first 3 characters of the month name are different. Personally, I think you would be better off using a table naming scheme that is not locale dependent like 'Sales_' + cast(datepart(yy, @PrmOrderDate) as char(4)) + '_' + cast(datepart(mm, @PrmOrderDate) as char(2)) To see the table names that you get now, run the following ... DECLARE @PrmOrderDate DATETIME; SET LANGUAGE N'us_english'; SET @PrmOrderDate = '01/31/2021'; -- set date here because the date literal format also depends on LANGUAGE SELECT SUBSTRING(DATENAME(mm, @PrmOrderDate), 1, 3) + CAST(DATEPART(yy, @PrmOrderDate) AS CHAR(4)) + 'Sales'; SET LANGUAGE N'Español'; SELECT SUBSTRING(DATENAME(mm, @PrmOrderDate), 1, 3) + CAST(DATEPART(yy, @PrmOrderDate) AS CHAR(4)) + 'Sales'; SET LANGUAGE N'ελληνικά'; SELECT SUBSTRING(DATENAME(mm, @PrmOrderDate), 1, 3) + CAST(DATEPART(yy, @PrmOrderDate) AS CHAR(4)) + 'Sales';
|
@bpd0018 : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
prmerger-automator
bot
added
sql/svc
Change sent to author
system-objects/subsvc
labels
|
Learn Build status updates of commit c7ad5bc: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
prmerger-automator
bot
added
the
aq-pr-triaged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are way more than 12 statements generated. You get one statement for each year and month combination for each language where the first 3 characters of the month name are different.
Personally, I think you would be better off using a table naming scheme that is not locale dependent like 'Sales_' +
cast(datepart(yy, @PrmOrderDate) as char(4)) +
'_' +
cast(datepart(mm, @PrmOrderDate) as char(2))
To see the table names that you get now, run the following ...
DECLARE @PrmOrderDate DATETIME;
SET LANGUAGE N'us_english';
SET @PrmOrderDate = '01/31/2021'; -- set date here because the date literal format also depends on LANGUAGE SELECT SUBSTRING(DATENAME(mm, @PrmOrderDate), 1, 3) + CAST(DATEPART(yy, @PrmOrderDate) AS CHAR(4)) + 'Sales'; SET LANGUAGE N'Español';
SELECT SUBSTRING(DATENAME(mm, @PrmOrderDate), 1, 3) + CAST(DATEPART(yy, @PrmOrderDate) AS CHAR(4)) + 'Sales'; SET LANGUAGE N'ελληνικά';
SELECT SUBSTRING(DATENAME(mm, @PrmOrderDate), 1, 3) + CAST(DATEPART(yy, @PrmOrderDate) AS CHAR(4)) + 'Sales';