Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update create-database-scoped-credential-transact-sql.md #9840

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

macarv-ms
Copy link
Contributor

typo in this document where it says, "Shared Access Signature cannot be used with Polybase." It should instead say, "Shared Access Signature can be used with Polybase."

typo in this document where it says, "Shared Access Signature cannot be used with Polybase." It should instead say, "Shared Access Signature can be used with Polybase."
Copy link
Contributor

@macarv-ms : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 9ace00a:

✅ Validation status: passed

File Status Preview URL Details
docs/t-sql/statements/create-database-scoped-credential-transact-sql.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Jak-MS
Copy link
Contributor

Jak-MS commented Jul 5, 2024

@VanMSFT
Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Jul 5, 2024
@VanMSFT
Copy link
Member

VanMSFT commented Jul 11, 2024

Thanks, @macarv-ms! This looks correct, but let's have @WilliamDAssafMSFT confirm.

@WilliamDAssafMSFT
Copy link
Contributor

Thanks, @macarv-ms, nice catch. This is a good reason why we don't put tech specs in Example text, this text is 6+ years old and clearly has changed. It'd be best to just remove this sentence.

@WilliamDAssafMSFT
Copy link
Contributor

Thanks again @macarv-ms.
Your commit will be merged and this article update is in flight. After the updated article is published, GitHub will list you as an article contributor.

#sign-off

Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @VanMSFT

@WilliamDAssafMSFT WilliamDAssafMSFT merged commit 06c76f1 into MicrosoftDocs:live Jul 11, 2024
1 check passed
Copy link
Contributor

PR 9840 has been merged from macarv-ms:patch-3 to MicrosoftDocs:live by WilliamDAssafMSFT.

@macarv-ms, @WilliamDAssafMSFT

Copy link
Contributor

Learn Build status updates of commit 51fc8c0:

✅ Validation status: passed

File Status Preview URL Details
docs/t-sql/statements/create-database-scoped-credential-transact-sql.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit fc4d5b2:

✅ Validation status: passed

File Status Preview URL Details
docs/t-sql/statements/create-database-scoped-credential-transact-sql.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants