Skip to content
This repository has been archived by the owner on Nov 11, 2021. It is now read-only.

Make css-grid example more semantic #421

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vansosnin
Copy link

What this PR does

Wraps images into buttons to better interactivity using the keyboard.

Requirements

  • My PR follows all applicable accessibility requirements (See .github/ACCESSIBILITY_REQS.md).
  • My PR follows the CSS code style guidelines (See .github/CSS_STYLE_REQS.md).
  • I have linted my code using npm run lint:css -- demoDirectoryName/**/*.css and npm run lint:js -- demoDirectoryName/**/*.js, and have fixed the errors.

@msftclas
Copy link

msftclas commented Oct 27, 2018

CLA assistant check
All CLA requirements met.

@ststimac
Copy link
Contributor

I'm pretty sure @gregwhitworth is the one who wrote the code for this.

Copy link

@lokeshmure lokeshmure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good..!

@gregwhitworth
Copy link
Contributor

Sorry for the delay on this and thank you for taking the time @vansosnin

You have changed the name computation by putting the img within the <button> which removes the audio only game that was built into the game (see "How to play" section). If you can please modify your code so that when you traverse to the button the word is read out loud allowing audio only users to build out the phrase and have a similiar puzzle experience but in a different dimension.

Please at-mention me upon completion so I get an email about the change. Thank you!

@vansosnin
Copy link
Author

@gregwhitworth thanks, and it's done

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants