Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Review: Web Notification #3186

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

API Review: Web Notification #3186

wants to merge 18 commits into from

Commits on Dec 9, 2022

  1. Add Web Notification API Spec draft

    @peiche-jessica
    peiche-jessica committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    1c1d3d0 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. Apply suggestions from code review 

    Co-authored-by: David Risney <dave@deletethis.net>
    @peiche-jessica @david-risney
    peiche-jessica and david-risney committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    952a757 View commit details
    Browse the repository at this point in the history

  2. Address initial feedback part 1

    @peiche-jessica
    peiche-jessica committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    e03a214 View commit details
    Browse the repository at this point in the history

  3. Add enum CoreWebView2TextDirectionKinds to c# API details

    @peiche-jessica
    peiche-jessica committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    cbd9d61 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2023

  1. Report* and CloseRequested

    @peiche-jessica
    peiche-jessica committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    5e22e5f View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2023

  1. Persistent -> ProfileNotificationReceivedEventHandler

    @peiche-jessica
    peiche-jessica committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    0b9a618 View commit details
    Browse the repository at this point in the history

  2. Address initial feedback part 2

    @peiche-jessica
    peiche-jessica committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    61d7ae7 View commit details
    Browse the repository at this point in the history

  3. Update ref doc

    @peiche-jessica
    peiche-jessica committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    c61f653 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2023

  1. Add DataAsJson and TryGetDataAsString

    @peiche-jessica
    peiche-jessica committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    b8395cb View commit details
    Browse the repository at this point in the history

  2. Add links to Notification.actions

    @peiche-jessica
    peiche-jessica committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    88418d0 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2023

  1. Apply API name suggestion

    @peiche-jessica
    peiche-jessica committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    0b6a3aa View commit details
    Browse the repository at this point in the history

  2. Clarify Handled and ReportXXX methods

    @peiche-jessica
    peiche-jessica committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    25207b4 View commit details
    Browse the repository at this point in the history

  3. Clarify deferral info

    @peiche-jessica
    peiche-jessica committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    8ef88d3 View commit details
    Browse the repository at this point in the history

  4. Fix sample code

    @peiche-jessica
    peiche-jessica committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    4908aaf View commit details
    Browse the repository at this point in the history

  5. Make ReportClicked and ReportClosed async

    @peiche-jessica
    peiche-jessica committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    993fe9f View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2023

  1. Address feedback

    @peiche-jessica
    peiche-jessica committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    320baf0 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2023

  1. Update sample

    @peiche-jessica
    peiche-jessica committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    16ba2bc View commit details
    Browse the repository at this point in the history

  2. Merge pull request #3049 from MicrosoftEdge/api-notification-draft 

    API Spec: Web Notification
    @peiche-jessica
    peiche-jessica committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    4493c00 View commit details
    Browse the repository at this point in the history