Add Spec: Critical Restart Required #4657
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add critical api --------- Co-authored-by: Diana Qu <xiaqu@microsoft.com> Co-authored-by: David Risney <dave@deletethis.net>
MikeHillberg
reviewed
Jul 3, 2024
| } | ||
| } | ||
|
|
||
| void WebView_CriticalRestartRequired(object sender, object e) |
There was a problem hiding this comment.
Suggested change
| void WebView_CriticalRestartRequired(object sender, object e) | |
| void WebView_CriticalRestartRequired(CoreWebView2Environment sender, object e) |
| ## Win32 C++ | ||
| ```cpp | ||
| void CoreWebView2InitializationCompleted() { | ||
| wil::com_ptr<ICoreWebView2Environment> m_webViewEnvironment; |
There was a problem hiding this comment.
Declare this as a member variable rather than a local, and then the reader realizes that it's initialized somewhere out-of-scope to this example
| used to perform A/B testing or remotely disable features) configurations to toggle feature flags. | ||
| However, once these payloads are received, there is no way to restart the WebView2 and apply the | ||
| payload. The purpose of this API is to detect such critical payloads and inform the end developer | ||
| so they may restart their app or their WebView2 or other appropriate action. |
There was a problem hiding this comment.
Does "restart" mean e.g. AppInstance.Restart? Would help to show this in the example.
Is there a way to just restart the WV2 though?
| /// | ||
| /// For apps with multiple processes that host WebView2s that share the same user data folder you | ||
| /// need to make sure all WebView2 instances are closed and the associated WebView2 Runtime | ||
| /// browser process exits. See `BrowserProcessExited` for more details. |
There was a problem hiding this comment.
If there's another app using WV2, but not the same UDF, then it won't cause a problem?
| /// `CriticalRestartRequired` gives you the awareness of these necessary WebView2 restarts, | ||
| /// allowing you to resolve issues faster than waiting for your end users to restart the app. | ||
| /// Depending on your app you may want to prompt your end users in some way to give | ||
| /// them a chance to save their state before you restart the WebView2. |
There was a problem hiding this comment.
Thank you, this is a great customer-focused API description :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An Critical Restart Required API to notify user for restart if needed