Skip to content

Commit

Permalink
⚙️ Cleanup for next release.
Browse files Browse the repository at this point in the history
  • Loading branch information
Mihara committed Jun 21, 2023
1 parent 87da767 commit 04d92c6
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 13 deletions.
6 changes: 1 addition & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

This is highly experimental.

Do not use this program for anything critical. Right now it's still very much an evening project waiting for feedback from people trying to use it. The signature format is not yet stable, and neither is the text mode format.
Do not use this program for anything critical. Right now it's still very much an evening project waiting for feedback from people trying to use it. The text mode format in particular is probably not stable.

Please experiment with it, that's the right word.

Expand Down Expand Up @@ -60,10 +60,6 @@ There is currently no way for us to know if a user's certificate has been revoke

Similarly, there is no way to prevent someone from using an expired certificate, since they can set the clock to what they want.

### RSA keys

`lotw-trust` currently assumes that LoTW issues and will forever issue only RSA-based x509 certificates. This is not guaranteed. In fact, it'd be better if they switched to something more modern, even if I would have to code to handle that.

### General caveats

I am not a cryptographer, I am a sociologist. Golang is not my best language, it's just the one that got me the result the quickest, while still allowing to easily make a cross-platform tool.
Expand Down
3 changes: 1 addition & 2 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,8 @@ require (
software.sslmate.com/src/go-pkcs12 v0.2.0
)

require github.com/x448/float16 v0.8.4 // indirect

require (
github.com/x448/float16 v0.8.4 // indirect
golang.org/x/crypto v0.10.0 // indirect
golang.org/x/sys v0.9.0 // indirect
)
6 changes: 0 additions & 6 deletions main.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import (
"fmt"
"io"
"log"
"math"
"os"
"path/filepath"
"strings"
Expand Down Expand Up @@ -326,11 +325,6 @@ func main() {

sigBlock := append([]byte(sigHeader), compressedSig...)

// If the sig block somehow got longer than 65kb, we have a problem anyway.
if len(sigBlock) > math.MaxUint16 {
l.Fatal("Signature block too long, which means something else went wrong.")
}

var savingData []byte

if textMode {
Expand Down

0 comments on commit 04d92c6

Please sign in to comment.